-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(daemon): add batch skill toggle API #8664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
531c5a2
feat(daemon): add batch skill toggle API
callmeYe ff35624
test(serve): update capability integration baseline
callmeYe 1ba3021
fix(daemon): apply skill batches atomically
callmeYe 642672f
Merge remote-tracking branch 'origin/main' into codex/batch-skill-toggle
callmeYe 960df14
test(daemon): pin Skill batch toggle contracts and fix docs examples
callmeYe 8df9605
test(daemon): pin Skill batch toggle mutants flagged in review
github-actions[bot] e8df053
test(daemon): cover Skill batch toggle edge cases
callmeYe 8c9222c
Merge remote-tracking branch 'origin/codex/batch-skill-toggle' into c…
callmeYe 895234b
docs(daemon): clarify Skill batch toggle contract notes from review
github-actions[bot] 7f59a22
test(daemon): pin Skill batch toggle cap semantics and SDK surface shape
github-actions[bot] f0dca84
test(daemon): pin Skill batch toggle mutants flagged in round-5 review
github-actions[bot] ee2ec6d
Merge branch 'main' into codex/batch-skill-toggle
qwen-code-dev-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| # Daemon Skill batch toggle | ||
|
|
||
| ## Problem | ||
|
|
||
| Remote Skill managers can toggle only one Skill per request. Closing several | ||
| Skills therefore requires client-side request orchestration and provides no | ||
| single response that records all target outcomes. | ||
|
|
||
| ## API | ||
|
|
||
| Add collection-level mutation routes: | ||
|
|
||
| - `POST /workspace/skills/enable` | ||
| - `POST /workspaces/:workspace/skills/enable` | ||
|
|
||
| The request body is: | ||
|
|
||
| ```json | ||
| { | ||
| "skillNames": ["review", "deploy", "missing"], | ||
| "enabled": false | ||
| } | ||
| ``` | ||
|
|
||
| `skillNames` is a non-empty string array with at most 100 entries. Names are | ||
| trimmed and deduplicated case-insensitively while preserving first-seen order. | ||
| The response is best-effort for expected target errors: valid targets are | ||
| validated against one status snapshot, persisted in one locked write, and | ||
| applied with one live-session refresh. Unknown, hidden, inactive-extension, | ||
| and locked targets are returned without blocking the valid targets. Unexpected | ||
| persistence and runtime-generation failures fail the whole request. | ||
|
|
||
| ```json | ||
| { | ||
| "enabled": false, | ||
| "activation": "applied", | ||
| "sessionsRefreshed": 2, | ||
| "sessionsFailed": 0, | ||
| "results": [ | ||
| { | ||
| "skillName": "review", | ||
| "enabled": false, | ||
| "changed": true | ||
| }, | ||
| { | ||
| "skillName": "deploy", | ||
| "enabled": false, | ||
| "changed": true | ||
| } | ||
| ], | ||
| "errors": [ | ||
| { | ||
| "skillName": "missing", | ||
| "code": "skill_not_found", | ||
| "error": "Skill not found: missing" | ||
| } | ||
| ] | ||
| } | ||
| ``` | ||
|
|
||
| `results` and `errors` each preserve request order within their own array; | ||
| the response does not reconstruct the original mixed ordering, so clients | ||
| re-match targets by `skillName`. | ||
|
|
||
| Malformed requests still fail as a whole with HTTP 400. Workspace trust, | ||
| authentication, client identity, and generation ownership use the same gates | ||
| as the single-Skill route. | ||
|
|
||
| ## Compatibility | ||
|
|
||
| Advertise `workspace_skill_batch_toggle` separately from | ||
| `workspace_skill_toggle`. Clients must pre-flight the new capability before | ||
| calling the collection route. The existing single-Skill route and response | ||
| remain unchanged. The collection routes are HTTP-only: the ACP | ||
| `_qwen/workspace/skills` dispatch surface stays read-only, matching the | ||
| single-Skill toggle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.