docs: document the Session Workflow setting - #8554
Conversation
|
✅ Qwen Triage finished — CI landed green on ✅ Qwen Triage 已完成 —— |
|
Thanks for the PR! Template looks good ✓ Problem: confirmed. Direction: aligned. Documenting an already-shipped experimental setting in the canonical settings reference is squarely in scope. The repo CHANGELOG records the setting's introduction (#8391), and the design contract lives in Size: not applicable — docs-only, one added line in one file. Approach: the scope is exactly right. A single table row, inserted where the schema declares the property (first in the Risk: no elevated risk signals. Moving on to code review. 🔍 中文说明感谢贡献! 模板完整 ✓ 问题:已确认。 方向:对齐。为已发布的实验性设置补充正式配置参考文档,完全在职责范围内。仓库 CHANGELOG 记录了该设置的引入(#8391),设计契约见 规模:不适用——仅文档改动,单文件新增一行。 方案:范围恰好。一行表格,插入位置与 schema 中的属性声明顺序一致( 风险:无升级风险信号。 进入代码审查 🔍 — Qwen Code · qwen3.8-max Reviewed at |
Code reviewFor a docs PR the review is fact-checking every claim in the new row against the code. I verified each one:
No blockers. The row is accurate, uses the same language as the schema description and design doc, and carries no unrelated changes. Test evidence — the PR's own CIAt review time the ubuntu unit suite is still running; the table below is a snapshot and the finalize job will refresh it once CI settles. Final CI results for
One row per check name (latest run); skipped checks omitted; failures sort first. / 每个检查名一行(取最新一次运行),省略 skipped,失败项排在最前。 Real-scenario testing
中文说明代码审查对文档 PR 来说,审查就是把新增行的每项声明与代码逐一核对,均已验证:
无阻塞项。该行内容准确,措辞与 schema 描述及设计文档一致,且不夹带任何无关改动。 测试证据——PR 自身的 CI审查时 ubuntu 单元测试仍在运行;下表为快照,CI 结束后 finalize 任务会刷新。precheck(格式/lint 门禁)与 Desktop Shell 任务已通过。macOS/Windows 测试与 CLI 集成任务在本次运行中被跳过——仅陈述观察到的事实,不断言原因;对单行 markdown 改动而言,ubuntu 套件加 precheck 是有意义的门禁。本环境不执行 fork PR 代码,因此未自行重跑任何内容。 真实场景测试不适用——仅文档改动,没有可在 tmux 中操作的用户可见行为。新增行中的每项事实声明已按上文所列,与配置 schema、设计契约和 Web Shell 实现逐一核对。 — Qwen Code · qwen3.8-max Reviewed at |
|
Confidence: 5/5 — a single-line docs row with every claim cross-checked against the schema, design contract, and implementation; nothing to fix. My independent take on "document the Session Workflow setting" would have been exactly this: one row in the settings reference's experimental table, taking type/default/restart semantics from the schema. The PR does precisely that and nothing more. The gap was real — the setting shipped in #8391 and is exposed through daemon workspace settings, yet no user-facing doc mentioned it. And the row's description isn't just plausible wording: each clause was verified — the DAG gating and Plan & Review rename in the Web Shell, the presentation-only boundary from the design contract, and the restart-free behavior (schema Verdict: approve. The ubuntu unit suite is still running on the reviewed commit, so approval is deferred until CI lands green on 中文说明Confidence: 5/5 —— 单行文档新增,每项声明均已与 schema、设计契约和实现核对,无需修改。 我对"补充 Session Workflow 设置文档"的独立方案正是如此:在配置参考的 experimental 表格中加一行,类型/默认值/重启语义取自 schema。本 PR 恰好做到这一点,没有任何多余内容。缺失是真实存在的——该设置在 #8391 中发布,并通过 daemon workspace 设置暴露,但没有任何面向用户的文档提及它。这行描述也不是看似合理的措辞而已:每一句都经过验证——Web Shell 中的 DAG 门控与 Plan & Review 重命名、设计契约中"仅改变呈现"的边界、以及免重启行为(schema 中 requiresRestart: false,且该开关在每次渲染时从实时 workspace 设置推导)。插入位置遵循 schema 属性顺序。这是一个小而准确的文档修复,易审查、易回滚。 结论:批准。ubuntu 单元测试仍在所审查的提交上运行,因此批准推迟到该提交的 CI 全绿后执行;finalize 任务届时会提交批准,若有检查变红则会标记该 PR。 — Qwen Code · qwen3.8-max Reviewed at |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
中文说明
— qwen3.8-max via Qwen Code /review (v0.21.5)
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship — CI landed green after the review. ✅
|
📄 Docs-only change — the automatic review ran at
Reviewed head: 中文说明📄 纯文档变更 —— 自动评审以 |
yiliang114
left a comment
There was a problem hiding this comment.
LGTM — existing approval matches the current head and CI is green.
|
Released in v0.22.0. |
What this PR does
Adds the missing user-facing reference for the experimental Session Workflow setting, including its default-off state, live-update behavior, Web Shell presentation changes, and observational boundary.
Why it's needed
The setting is shipped in the configuration schema and exposed through daemon workspace settings, but users could not discover its key or behavior in the configuration reference. Documenting it makes the opt-in path and its limits explicit without implying a new execution or approval system.
Reviewer Test Plan
How to verify
Compare the documented key, boolean type, default value, and restart behavior with the configuration schema. In the daemon Web Shell, enable the setting and confirm that the Workflow DAG appears and the existing plan mode is labeled Plan & Review; disable it and confirm that ordinary Plan and Todo behavior remains unchanged.
The focused configuration-schema suite passed 40 tests. The focused Web Shell application, mode-selector, approval-dialog, and Todo suites passed 423 tests. The repository build, workspace typecheck, formatting check, and diff whitespace check also passed.
Evidence (Before & After)
N/A — documentation-only change.
Tested on
Environment (optional)
macOS 27.0 on arm64, Node.js 24.18.0, and npm 11.16.0 in a local worktree without sandboxing.
Risk & Scope
Linked Issues
N/A.
中文说明
本 PR 做了什么
补充实验性 Session Workflow 设置缺失的用户参考说明,包括默认关闭状态、无需重启即可生效、Web Shell 展示变化,以及仅观察不调度的边界。
为什么需要
该设置已经随配置 schema 发布,并通过 daemon workspace 设置暴露,但用户无法在配置参考中找到它的键名或行为。补充文档可以明确启用方式和限制,同时避免让人误以为它引入了新的执行或审批系统。
Reviewer 测试计划
如何验证
将文档中的键名、布尔类型、默认值和重启行为与配置 schema 逐项比较。在 daemon Web Shell 中启用该设置,确认 Workflow DAG 出现,且现有 plan 模式显示为 Plan & Review;关闭后,确认普通 Plan 与 Todo 行为保持不变。
聚焦的配置 schema 测试套件有 40 个测试通过。聚焦的 Web Shell 应用、模式选择器、审批对话框和 Todo 测试套件有 423 个测试通过。仓库构建、workspace 类型检查、格式检查和 diff 空白检查也均通过。
前后证据
N/A——仅文档改动。
测试平台
环境(可选)
macOS 27.0(arm64)、Node.js 24.18.0、npm 11.16.0,本地 worktree,未启用 sandbox。
风险与范围
关联 Issue
N/A。