Skip to content

ci: externalize PR review timeout settings to repository variables #8460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 1 commit into from
Aug 3, 2026
Merged

ci: externalize PR review timeout settings to repository variables #8460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions .github/workflows/qwen-code-pr-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,13 @@ jobs:
startsWith(github.event.review.body, '@qwen-code /review ') ||
startsWith(github.event.review.body, format('@qwen-code /review{0}', '\n'))) &&
needs.authorize.outputs.should_review == 'true'))
# 300 (not 260): the per-review budget auto-scales to 240 minutes for any
# non-small PR (see "Run review"), and the shared retry budget plus comment
# posting need headroom above that within the job-level cap.
timeout-minutes: 300
# The per-review budget auto-scales to QWEN_REVIEW_MAX_TIMEOUT_MINUTES
# for any non-small PR (see "Run review"), and the shared retry budget
# plus comment posting need headroom above that within the job-level cap.
# Tunable via the `QWEN_REVIEW_JOB_TIMEOUT_MINUTES` repository variable
# (default: 360); must stay above QWEN_REVIEW_MAX_TIMEOUT_MINUTES so
# retry plus posting never hit the cap.
timeout-minutes: '${{ fromJSON(vars.QWEN_REVIEW_JOB_TIMEOUT_MINUTES) }}'
runs-on: '${{ (github.repository == ''QwenLM/qwen-code'' && vars.MAINTAINER_ECS_RUNNER_DISABLED != ''true'') && fromJSON(''["self-hosted", "linux", "x64", "ecs-qwen"]'') || fromJSON(''["ubuntu-latest"]'') }}'
permissions:
contents: 'read'
Expand Down Expand Up @@ -721,8 +724,9 @@ jobs:
if [ "$TIMEOUT_MINUTES" -le 5 ]; then
fail "timeout_minutes must be greater than 5"
fi
if [ "$TIMEOUT_MINUTES" -gt 240 ]; then
fail "timeout_minutes must not exceed 240 minutes"
MAX_TIMEOUT_MINUTES="${{ vars.QWEN_REVIEW_MAX_TIMEOUT_MINUTES }}"
if [ "$TIMEOUT_MINUTES" -gt "$MAX_TIMEOUT_MINUTES" ]; then
fail "timeout_minutes must not exceed ${MAX_TIMEOUT_MINUTES} minutes"
fi

# Size-aware default timeout. A fixed 180-minute default times out
Expand All @@ -732,9 +736,10 @@ jobs:
# same PR had finished in ~90 minutes on a less loaded runner, so the
# variance alone argues for a wide budget. When the caller did not
# pass an explicit --timeout, give any non-small PR (> 300 changed
# lines, additions + deletions) the full 240 cap; small PRs keep the
# proven 180. An explicit --timeout always wins. A size lookup failure
# falls back to the 180 default rather than failing the review.
# lines, additions + deletions) the full QWEN_REVIEW_MAX_TIMEOUT_MINUTES
# cap; small PRs keep the proven 180. An explicit --timeout always wins;
# a size lookup failure falls back to the 180 default rather than
# failing the review.
EFFECTIVE_TIMEOUT_MINUTES="$TIMEOUT_MINUTES"
if [ "${TIMEOUT_EXPLICIT:-false}" != "true" ]; then
PR_SIZE_LINES=''
Expand All @@ -748,7 +753,7 @@ jobs:
if [ "$PR_SIZE_LINES" -le 300 ]; then
EFFECTIVE_TIMEOUT_MINUTES=180
else
EFFECTIVE_TIMEOUT_MINUTES=240
EFFECTIVE_TIMEOUT_MINUTES="${{ vars.QWEN_REVIEW_MAX_TIMEOUT_MINUTES }}"
fi
echo "PR #${PR_NUMBER} changed ${PR_SIZE_LINES} lines; auto timeout ${EFFECTIVE_TIMEOUT_MINUTES} minutes."
else
Expand Down Expand Up @@ -964,11 +969,12 @@ jobs:
echo "Skipping fallback comment: PR #${PR_NUMBER} moved from ${EXPECTED_HEAD_SHA} to ${current_head}." >> "$GITHUB_STEP_SUMMARY"
exit 0
fi
MAX_TIMEOUT_MINUTES="${{ vars.QWEN_REVIEW_MAX_TIMEOUT_MINUTES }}"
if [ "$FAILURE_KIND" = "timeout" ]; then
if [ "$TIMEOUT_MINUTES" -lt 240 ]; then
body="**Qwen Code review timed out.** ${FAILURE_REASON} For large PRs, retry with a longer timeout by commenting: \`@qwen-code /review --timeout=240\`. See [workflow logs](${RUN_URL})."
if [ "$TIMEOUT_MINUTES" -lt "$MAX_TIMEOUT_MINUTES" ]; then
body="**Qwen Code review timed out.** ${FAILURE_REASON} For large PRs, retry with a longer timeout by commenting: \`@qwen-code /review --timeout=${MAX_TIMEOUT_MINUTES}\`. See [workflow logs](${RUN_URL})."
else
body="**Qwen Code review timed out.** ${FAILURE_REASON} This run already used the maximum 240 minute timeout. See [workflow logs](${RUN_URL})."
body="**Qwen Code review timed out.** ${FAILURE_REASON} This run already used the maximum ${MAX_TIMEOUT_MINUTES} minute timeout. See [workflow logs](${RUN_URL})."
fi
elif [ "$FAILURE_KIND" = "quota" ]; then
# A quota reset is typically hours out, so an in-run retry can't
Expand Down
Loading