-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(channels): support group pairing #8440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wenshao
merged 14 commits into
QwenLM:main
from
qqqys:codex/issue-7209-channel-group-pairing-api
Aug 7, 2026
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9ff19fd
feat(channels): support group pairing
qqqys e3da5f0
fix(channels): address group pairing review
qqqys 842031c
fix(web-shell): show group pairing management
qqqys 8af2dcc
fix(channels): recheck group pairing before history backfill
qqqys 7ae9f15
test(channels): verify group approval isolation
qqqys 4aea79d
Merge branch 'main' into codex/issue-7209-channel-group-pairing-api
qwen-code-dev-bot 5c49687
fix(channels): address group pairing review findings and pin behavior…
qwen-code-dev-bot 9f7eb5c
fix(channels): address group pairing review findings (#8440)
qwen-code-dev-bot cc56445
fix(channels): address group pairing review findings round 7 (#8440)
qwen-code-dev-bot 0e3c784
Merge remote-tracking branch 'origin/main' into codex/issue-7209-chan…
qwen-code-dev-bot ae4fbb2
fix(channels): address group pairing review findings round 8 (#8440)
qwen-code-dev-bot 286150b
fix(channels): address group pairing review findings round 9 (#8440)
qwen-code-dev-bot f46e265
Merge branch 'main' into codex/issue-7209-channel-group-pairing-api
qwen-code-dev-bot 9c71442
Merge branch 'main' into codex/issue-7209-channel-group-pairing-api
wenshao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] This diff recommends
groupPolicy: "pairing"here but leaves the unchanged Security section above still saying "Always usesenderPolicy: \"allowlist\"with explicitallowedUserson public projects" unconditionally. All GitLab envelopes are group envelopes (buildEnvelopehardcodesisGroup: true) and the pairing preflight early-return precedes the sender gate — so once a project is approved,senderPolicy/allowedUsersgate nothing on this adapter. — Failure scenario: an operator on a public GitLab project follows both pieces of advice in this file; after approving the project — the step this paragraph instructs — ANY GitLab user who @mentions the bot drives the agent in the operator's cwd, despite the allowlist. (The behavior is intended per overview.md; the defect is the same-file contradiction.) Suggested fix: add a pairing caveat to the Security section — undergroupPolicy: "pairing"on GitLab, access is controlled per-project once approved; all GitLab traffic is group traffic, sosenderPolicy/allowedUsersdo not gate project members.中文说明
本 diff 在此处推荐
groupPolicy: "pairing",但上方未改动的 Security 一节仍无条件地要求“公开项目务必使用senderPolicy: \"allowlist\"并显式配置allowedUsers”。GitLab 的所有 envelope 都是群 envelope(buildEnvelope硬编码isGroup: true),且 pairing 的 preflight 提前返回先于发送者门执行——因此项目一旦获批,senderPolicy/allowedUsers在该 adapter 上不起任何拦截作用。失败场景:公开 GitLab 项目的运营者同时遵循本文件的两条建议;批准项目(即本段指导的步骤)后,任何 @ 机器人的 GitLab 用户都能在运营者的 cwd 中驱动 agent,allowlist 形同虚设。(该行为本身是 overview.md 记录的预期设计;缺陷是同一文件内的自相矛盾。)建议修复:在 Security 一节补充 pairing 说明——GitLab 上的groupPolicy: "pairing"批准后即按项目整体授权,且 GitLab 流量全部是群流量,senderPolicy/allowedUsers不约束项目成员。— qwen3.8-max via Qwen Code /review (v0.21.5)