Skip to content

fix(web-shell): add explicit ::selection for message content in Firefox #8417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 11 commits into from
Aug 4, 2026
Merged

fix(web-shell): add explicit ::selection for message content in Firefox #8417

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6f7a027
fix(web-shell): add explicit ::selection for message content in Firefox
C0d3N1nja97342 Aug 3, 2026
66fbd94
fix: use fixed color instead of non-existent CSS variable
C0d3N1nja97342 Aug 3, 2026
334a868
test(web-shell): pin ::selection rule and soften root-cause framing
C0d3N1nja97342 Aug 3, 2026
b918dfd
Merge branch 'main' into fix/web-shell-selection-highlight
wenshao Aug 3, 2026
0a28f6f
fix(web-shell): move ::selection rule to component-scoped globals.css
C0d3N1nja97342 Aug 3, 2026
d4e93da
Merge branch 'main' into fix/web-shell-selection-highlight
wenshao Aug 3, 2026
e804620
Merge branch 'main' into fix/web-shell-selection-highlight
wenshao Aug 3, 2026
870d759
test(web-shell): pin ::selection across all rows and in the lib bundle
C0d3N1nja97342 Aug 4, 2026
2a21e9a
test(web-shell): assert ::selection on selectable wrapper rows, not d…
C0d3N1nja97342 Aug 4, 2026
5ebdd5d
Merge remote-tracking branch 'upstream/main' into fix/web-shell-selec…
C0d3N1nja97342 Aug 4, 2026
a48f3c8
test(web-shell): match ::selection lib-bundle pin by effect, not nota…
C0d3N1nja97342 Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/web-shell/client/styles/standalone.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,18 @@ textarea,
user-select: text;
}

/*
* Firefox does not paint the default selection highlight for text whose
* element chain passes through a `display: contents` element (the
* `data-user-selectable` wrapper on MessageItem). The logical selection
* (copy, selectionchange popup) works fine - only the visual highlight is
* missing. An explicit `::selection` background makes Firefox paint the
* highlight where the default painting fails. #8214.
*/
[data-user-selectable] ::selection {
background: hsl(210 100% 50% / 30%);
}

/*
* iOS Safari auto-zooms any <input> / <textarea> / contenteditable whose
* computed font-size is < 16px when focused. The composer editor sits at
Expand Down
Loading