-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(review): Add Maven multi-module verification #8394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
8320dda
refactor(review): Extract npm toolchain adapter
wenshao 50a91f4
feat(review): Add Maven multi-module verification
wenshao ad4bab5
test(review): pin adapter delegation, exec fallback, single-root guard
wenshao 4c1b3bb
Merge branch 'refactor/review-toolchain-adapter' of https://github.co…
qwen-code-dev-bot 187a272
test(review): align Agent 7 brief assertion with build-test command (…
qwen-code-dev-bot ab61037
fix(review): Tighten Maven verification evidence
wenshao 5fa39d6
Merge remote-tracking branch 'wenshao/refactor/review-toolchain-adapt…
wenshao 2f9a3e1
Merge branch 'main' into refactor/review-toolchain-adapter
qwen-code-dev-bot f7602ea
fix(review): Reject inactive nested Maven projects
wenshao f308f0b
fix(review): Tighten Maven evidence, scope, and base-tree gate (#8394)
qwen-code-dev-bot 7f0f42c
fix(review): Address Maven verification review feedback (#8394)
qwen-code-dev-bot 856666f
fix(review): Clamp Maven test counts and skip doc-only module runs (#…
qwen-code-dev-bot 117dbe7
fix(review): Harden Maven classification and Test Plan rulings (#8394)
qwen-code-dev-bot 4304843
fix(review): Close round-3 Maven verification and Test Plan gaps (#8394)
qwen-code-dev-bot e425e0e
fix(review): Keep Maven source failures out of the infra carve-out (#…
qwen-code-dev-bot 69dc0ee
Merge branch 'main' into refactor/review-toolchain-adapter
wenshao d25cad5
Merge branch 'main' into refactor/review-toolchain-adapter
qwen-code-dev-bot 923ee6e
fix(review): Close round-4 Maven evidence and Test Plan gaps (#8394)
qwen-code-dev-bot c403ccc
fix(review): Close round-5 toolchain settlement and classification ga…
qwen-code-dev-bot 912641f
fix(review): Close round-6 diagnostic, deadline, and hardening gaps (…
qwen-code-dev-bot b6e2bb5
Merge branch 'main' into refactor/review-toolchain-adapter
qwen-code-dev-bot fc6092f
Merge main into review-toolchain adapter; close round-6 findings (#8394)
qwen-code-dev-bot c97cf65
Merge branch 'main' into refactor/review-toolchain-adapter
qwen-code-dev-bot 96101d3
Merge branch 'main' into refactor/review-toolchain-adapter
qwen-code-dev-bot fc6bcb1
fix(review): Close round-7 budget, parser, and settlement gaps (#8394)
qwen-code-dev-bot 4fbc7f3
Merge branch 'main' into refactor/review-toolchain-adapter
qwen-code-dev-bot c905cf3
Merge branch 'main' into refactor/review-toolchain-adapter
qwen-code-dev-bot 8a27463
fix(review): Close round-8 Maven routing, settlement, and evidence ga…
qwen-code-dev-bot db9ffc7
fix(review): Close round-9 Maven evidence-gating and deadline defects…
qwen-code-dev-bot 2be30c5
fix(review): Close round-10 Maven adapter bounds, settlement, and evi…
qwen-code-dev-bot 28c13cd
fix(review): Close round-11 Maven evidence, inheritance, and settleme…
qwen-code-dev-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] R5-8: The assertion this pair replaced (
toContain('npm run build')) was the only pin of Agent 7's no-substitution rule; the rewritten rule "Do not substitute hand-written npm or Maven commands." (lib/agent-briefs.ts:448— verified verbatim, exactly one occurrence repo-wide) is pinned by no test. Deleting that sentence ships green, and it is the only steering against hand-run full builds — the pattern the same paragraph records as timing out 71 times and verifying nothing. The house's own practice pins this class of brief prose (the verify brief's "do not just trace it — run it"). — Failure scenario: a future edit deletes the sentence → the entire suite stays green → Agent 7 can silently regress to hand-run full builds.中文说明
这对断言替换掉的
toContain('npm run build')是 Agent 7 禁止手写命令规则的唯一钉住;新规则"Do not substitute hand-written npm or Maven commands."(lib/agent-briefs.ts:448,已核实原文全仓仅一处)没有任何测试钉住。删除该句整套测试仍绿,而它是唯一阻止手写全量构建的约束——同一段落记载该模式曾超时 71 次且什么都没验证。仓库自身惯例就是钉住这类简报语句(verify 简报的 "do not just trace it — run it")。失败场景:未来编辑删除该句 → 全套测试保持绿色 → Agent 7 可静默退回手写全量构建。— qwen3.8-max via Qwen Code /review (v0.21.5)