Skip to content

fix(cli): let ESC cancel ongoing work before popping queued messages #8353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 21 commits into from
Aug 8, 2026
Merged

fix(cli): let ESC cancel ongoing work before popping queued messages #8353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ccfb598
fix(cli): let ESC cancel ongoing work before popping queued messages
C0d3N1nja97342 Aug 2, 2026
556a8aa
fix: narrow ESC fall-through to empty buffer + add regression tests
C0d3N1nja97342 Aug 2, 2026
06592cb
fix: correct ESC comment to reflect KeypressContext broadcast model
C0d3N1nja97342 Aug 2, 2026
427bd96
fix: correct comment to accurately describe return false -> BaseTextI…
C0d3N1nja97342 Aug 2, 2026
26c6927
test(ui): add positive AppContainer ESC cancel regression test
C0d3N1nja97342 Aug 3, 2026
d2dceb6
test(ui): clarify ESC cancel test scope vs end-to-end drain
C0d3N1nja97342 Aug 3, 2026
4cfcb9a
test(ui): pin ESC return-false branch and dedupe getGlobalKeypress
C0d3N1nja97342 Aug 4, 2026
b82068a
test(ui): escape raw ESC byte in cancel test fixture
C0d3N1nja97342 Aug 4, 2026
e8dd99b
Merge remote-tracking branch 'upstream/main' into fix/esc-cancel-work…
C0d3N1nja97342 Aug 4, 2026
ef3d6c2
Merge branch 'main' into fix/esc-cancel-work-while-responding
wenshao Aug 4, 2026
8487882
test(ui): assert buffer stays empty on ESC cancel + fix test comment
C0d3N1nja97342 Aug 4, 2026
9c04426
test(ui): cover queue+text ESC and double-ESC-clear while responding
C0d3N1nja97342 Aug 5, 2026
3f24262
test(ui): dedupe escKey fixture and tighten double-ESC timing
C0d3N1nja97342 Aug 5, 2026
e31d4aa
test(ui): add missing removeGoalTurns to cancel-handler queue mock
C0d3N1nja97342 Aug 5, 2026
045c827
test(ui): reuse getGlobalKeypress in vim-INSERT cancel test
C0d3N1nja97342 Aug 5, 2026
43e89c4
test+docs(ui): escape ESC byte in shared fixture and document Respond…
C0d3N1nja97342 Aug 5, 2026
1ac1d27
docs(ui): correct ESC/Up-Arrow queue-pop description to match code
C0d3N1nja97342 Aug 5, 2026
42017c6
Merge branch 'main' into fix/esc-cancel-work-while-responding
wenshao Aug 6, 2026
e83cbf3
refactor(ui): drop dead Responding ESC guard per maintainer review
C0d3N1nja97342 Aug 6, 2026
8cdf2e0
docs(ui): correct four review comments in ESC cancel path
C0d3N1nja97342 Aug 6, 2026
05a4aa0
docs(ui): correct subscription-order and double-ESC-cancel comments
C0d3N1nja97342 Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading