docs: document compaction and image model selection - #8348
Conversation
|
Thanks for the PR! Template looks good ✓ — all required sections present, including the bilingual body. Problem: this is a genuine documentation gap, not a theoretical one. The Direction: aligned. This documents already-shipped behavior with no runtime change, which is squarely in scope. It touches model selection only descriptively (no logic changes), so no escalation needed. Size: not applicable — docs-only, 2 files under Approach: the scope feels right. Two focused additions — a Risk: no elevated risk signals — neither changed file matches the high-risk paths from the revert-history analysis. Moving on to code review. 🔍 中文说明感谢贡献! 模板完整 ✓ —— 所有必需章节齐全,包含中英双语正文。 问题:这是一个真实的文档缺口,而非理论性问题。 方向:对齐。本 PR 仅描述已发布的行为,不改动运行时,完全在范围内。它只以描述方式涉及模型选择(不改逻辑),无需升级。 规模:不适用 —— 纯文档, 方案:范围合理。两处聚焦的新增——设置参考中新增 风险:无升级风险信号 —— 两个改动文件均未命中基于 revert 历史分析的高风险路径。 进入代码审查 🔍 — Qwen Code · qwen3.8-max-preview Reviewed at |
Code reviewFor a docs PR the review is really an accuracy check, so I read the PR title + motivation and formed my own baseline first: I'd add a I then verified each documented claim against the shipped code:
The new entries sit alongside the existing Nothing blocks this. Test evidenceThis is an unattended CI run, so I'm quoting the PR's own CI checks for the reviewed commit rather than running anything. Precheck passed; the load-bearing unit suite ( Final CI results for
One row per check name (latest run); skipped checks omitted; failures sort first. / 每个检查名一行(取最新一次运行),省略 skipped,失败项排在最前。 No sandboxed-lane line here: this is a docs-only change with no behavioural claim to settle — the unit suite the docs reference (model-command and configuration tests) is what CI is running, and there is no runtime behaviour for 中文说明代码审查对文档 PR 而言,审查实质上是准确性核验。我先只看标题与动机,形成自己的基线:我会在设置参考中新增 随后我逐条对照已发布代码核验了文档声明:
新条目紧邻现有 无阻塞项。 测试证据这是无人值守的 CI 运行,因此我引用该 PR 针对被审 commit 的自身 CI 检查,而非自行运行任何代码。Precheck 已通过;承载主要验证的单元测试( 无沙箱验证行:这是纯文档改动,没有需要验证的行为声明——文档所引用的单元测试(模型命令与配置测试)正是 CI 正在运行的内容,没有可供 — Qwen Code · qwen3.8-max-preview Reviewed at |
|
Confidence: 5/5 — clean across every stage; the docs are accurate against the shipped code and I'd merge without hesitation. Stepping back: this is exactly the kind of PR that's easy to underrate because it's small, but it closes a real discoverability gap. The settings and The diff is minimal and self-consistent: two settings rows that reuse the existing Approval is deferred only because the unit suite is still running on the reviewed commit — approval deferred until CI lands green on 中文说明置信度:5/5 —— 各阶段均干净;文档与已发布代码一致,可以毫不犹豫地合并。 退一步看:这类 PR 因为体量小很容易被低估,但它填补了一个真实的可发现性缺口。这些设置与 diff 极简且自洽:两行设置条目复用现有 仅因被审 commit 上的单元测试仍在运行而暂缓批准——待 CI 在该 commit 上全绿后批准。finalize 工作流会在所有检查全绿后发布钉住该 commit 的批准;若有任何检查变红或 head 移动,则会暂缓。 — Qwen Code · qwen3.8-max-preview Reviewed at |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
Reviewed. Suggestions are inline.
中文说明
已审查。 建议见行内评论。
— qwen3.8-max-preview via Qwen Code /review
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship — CI landed green after the review. ✅
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
Reviewed. Suggestions are inline.
中文说明
已审查。 建议见行内评论。
— qwen3.8-max-preview via Qwen Code /review
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
中文说明
— qwen3.8-max-preview via Qwen Code /review
Review Summary — PR #8348docs: document compaction and image model selection Verdict: No blockers. Clean documentation-only change (+53/−39, 2 files). What was verifiedI cross-checked every factual claim in the new docs against the implementation on
Notes
LGTM — ship it. |
|
@qwen-code /triage |
|
Sandboxed verification: This PR changes documentation/assets only — there is no code to execute, so a sandboxed verification has nothing to verify. 中文 — 判定:
|
|
Thanks for the PR! Template looks good ✓ Problem: observed gap — Direction: aligned — documenting existing, shipped features is squarely within scope. No CHANGELOG reference needed for a docs-only gap fill. Size: not applicable (docs only, no core paths touched). Approach: the scope feels right. Two new settings sections in Risk: no elevated risk signals. Moving on to code review. 🔍 中文说明感谢贡献! 模板完整 ✓ 问题:已观测到的文档缺口—— 方向:对齐——为已发布的现有功能补充文档,完全在范围内。 规模:不适用(仅文档,未触及核心路径)。 方案:范围合理。 风险:无升级风险信号。 进入代码审查 🔍 — Qwen Code · qwen3.8-max-preview Reviewed at |
Code ReviewVerified every documented claim against the codebase:
No correctness issues, no convention violations, no scope creep. TestingN/A — documentation-only change with no user-visible behavioral impact.
All CI checks green on the reviewed commit. No failures. 中文说明代码审查逐条对照代码库验证了文档中的每一项声明:
无正确性问题,无规范违反,无范围蔓延。 测试不适用——仅文档改动,无用户可见的行为影响。 CI 全部通过,无失败。 — Qwen Code · qwen3.8-max-preview Reviewed at |
|
Confidence: 5/5 — clean docs gap-fill, every claim verified against the implementation, CI green, nothing to second-guess. This is exactly the kind of PR that's easy to review and easy to merge. The author identified a real documentation gap (two shipped model selectors with zero docs coverage), verified the wording against the settings schema, config resolution, and command implementation, and kept the diff to the minimum — two new settings sections and two new table rows, with only the mechanical column-width adjustment as a side effect. I independently checked every factual claim: the If I had to maintain this in six months, I'd thank the author — the new sections follow the exact same format as the adjacent 中文说明置信度:5/5——干净的文档补缺,每项声明均已对照实现验证,CI 全绿,无需犹豫。 这正是那种容易审查、容易合并的 PR。作者发现了一个真实的文档缺口(两个已发布的模型选择方式完全没有文档覆盖),对照设置 schema、配置解析和命令实现核验了措辞,并将 diff 控制在最小范围——两个新设置小节和两行新表格行,唯一的副作用是机械性的列宽调整。 我独立检查了每一项事实声明: — Qwen Code · qwen3.8-max-preview Reviewed at |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
|
Released in v0.21.4. |
What this PR does
Documents the existing auxiliary model selectors for chat compression and built-in image generation. The command reference now shows how to select these models and clear the compression override, while the settings reference records their defaults, fallback or availability behavior, and image-provider requirements.
Why it's needed
Both selectors and settings are already shipped and exposed by the settings schema, but the user documentation only listed the fast, voice, and vision model paths. Users could not discover how to configure a dedicated compression model or why image generation remains unavailable without a valid image-only provider route.
Reviewer Test Plan
How to verify
Confirm that the model command reference lists the compression and image selectors with valid examples. Confirm that the settings reference states that an empty compression override falls back to the main model and that image generation requires an image-only provider with a base URL and credential environment key. The documented behavior is covered by the focused model-command and configuration tests.
Evidence (Before & After)
N/A — documentation-only change.
Tested on
Environment (optional)
Local macOS 27.0 worktree with Node.js 24.18.0 and npm 11.16.0. Prettier checks, focused unit tests, the full build, and the full typecheck completed successfully.
Risk & Scope
Linked Issues
N/A.
中文说明
本 PR 的内容
记录现有的聊天压缩与内置图像生成辅助模型选择方式。命令参考现在说明如何选择这两类模型以及如何清除压缩模型覆盖;设置参考同时记录其默认值、回退或可用性行为,以及图像提供方必须满足的条件。
为什么需要此改动
这两种选择方式及对应设置已经发布,并由设置 schema 对外公开,但用户文档此前只列出了快速、语音和视觉模型路径。用户无法从文档中发现如何配置专用压缩模型,也不清楚缺少有效的纯图像提供方路由时图像生成为何不可用。
Reviewer 测试计划
验证方式
确认模型命令参考列出了压缩和图像模型选择方式,并给出有效示例。确认设置参考说明:压缩模型覆盖为空时会回退到主模型;图像生成需要一个包含基础 URL 和凭据环境变量键的纯图像提供方。相关文档行为已由聚焦的模型命令与配置单元测试覆盖。
证据(改动前后)
N/A——仅文档改动。
已测试平台
环境(可选)
本地 macOS 27.0 worktree,Node.js 24.18.0,npm 11.16.0。Prettier 检查、聚焦单元测试、完整构建和完整类型检查均成功完成。
风险与范围
关联 Issue
N/A。