-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(core): unblock history pagination on oversized transcript turns #8335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] The backward-pagination oversized-turn fix (replacing
throwwithbreak) can be reverted on its own with every affected test staying green — no test in this diff independently gates the backward path's first-record-exceeds-budget handling. — Concrete cost: a future refactor re-introducing athrowinselectBackwardPageUuidswould not be caught.The existing test sets
maxBytesexactly equal to the first backward record's byte count, so the oldbytes > maxBytesthrow condition is never true. A test withmaxBytesstrictly less than the first record's bytes (e.g.Buffer.byteLength(JSON.stringify(finalAnswer)) - 1) would trigger the old throw and pin the fix.中文说明
向后分页的超大 turn 修复(将
throw替换为break)可以被单独回退而所有受影响的测试仍为绿色——本 diff 中没有测试独立地固定住向后路径的首条记录超预算处理。具体代价:未来在selectBackwardPageUuids中重新引入throw的重构不会被捕获。现有测试将
maxBytes设为恰好等于首条向后记录的字节数,因此旧的bytes > maxBytes抛出条件永远不为真。建议将maxBytes设为严格小于首条记录字节数(如Buffer.byteLength(JSON.stringify(finalAnswer)) - 1),即可触发旧抛出并固定住此修复。— qwen3.8-max-preview via Qwen Code /review (v0.21.3)