Repository navigation
fix(cli): enable footer text selection in VP mode #8329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DragonnZhang
merged 6 commits into
QwenLM:main
from
DragonnZhang:dragon/fix-8131-statusline-selection
Aug 12, 2026
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
620e982
fix(cli): enable footer text selection in VP mode
DragonnZhang bd1b424
test(cli): cover cross-region footer drag
DragonnZhang 70e9318
Merge upstream main into statusline selection fix
DragonnZhang 964c72a
fix(cli): stabilize footer selection invalidation
DragonnZhang fc08ff6
chore: merge upstream main into footer text selection fix
qwen-code-dev-bot de89559
fix(cli): preserve line selection from layout cells
DragonnZhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Statusline text selection | ||
|
|
||
| ## Problem | ||
|
|
||
| Virtualized History enables terminal-wide mouse tracking, so the terminal cannot | ||
| provide native text selection. Qwen Code's application-level selection currently | ||
| accepts presses only inside the history viewport, leaving the footer/statusline | ||
| unselectable. | ||
|
|
||
| ## Design | ||
|
|
||
| Keep one selection controller and give it an ordered list of selectable frame | ||
| rectangles. The history viewport remains the primary rectangle. The default | ||
| layout passes a ref for the rendered footer through `Composer`, and | ||
| `MainContent` supplies its measured rectangle as the second target. | ||
|
|
||
| The controller records which rectangle owns a selection when the press starts. | ||
| Drag coordinates remain clamped to that rectangle, and frame/layout changes are | ||
| compared only within it. Input, dialogs, scrollbars, and other controls remain | ||
| outside the selectable targets, so their existing mouse behavior is unchanged. | ||
|
|
||
| This applies only to the existing Virtualized History path. Normal-buffer mode | ||
| continues to use terminal-native selection. | ||
|
|
||
| ## Verification | ||
|
|
||
| - Dragging within history still highlights and copies history text. | ||
| - Dragging within a multi-line footer highlights and copies footer text. | ||
| - Presses in the gap between the history and footer do not start a selection. | ||
| - Footer selection is cleared when its content or layout changes. | ||
| - A live Virtualized History session can copy visible statusline text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.