feat(channels): add Web Shell management support for GitHub and GitLab - #8307
Closed
OrbitZore wants to merge 0 commit into
Closed
feat(channels): add Web Shell management support for GitHub and GitLab#8307OrbitZore wants to merge 0 commit into
OrbitZore wants to merge 0 commit into
Conversation
Collaborator
|
Qwen precheck requires maintainer approval before automated triage/review. Head SHA: Reason:
A maintainer with write access can inspect the PR and manually request a run with |
OrbitZore
force-pushed
the
feat/webshell-github-gitlab-management
branch
from
August 1, 2026 10:08
23aa4e4 to
d962b82
Compare
Contributor
|
Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. 中文请勿对活跃的 PR 执行 rebase 或 force-push,因为这会使已有的评审评论失效。另外,供日后参考:作为集成流程的一部分,机器人始终会自动将所有改动压缩(squash)为单个提交。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds
managementdescriptors to the GitHub and GitLab channel plugins so the Web Shell channel management UI can configure them. Previously only DingTalk, WeCom, and Feishu were manageable through the Web Shell; GitHub and GitLab required manualsettings.jsonediting.Each plugin now declares two form fields:
token(secret, required) andbaseUrl(string, optional), both environment-variable resolvable. The Web Shell frontend allowlist is extended to includegithubandgitlab, and the corresponding unit tests are updated.Why it's needed
Requested in #7862 (comment) — users should be able to set up GitHub and GitLab channels entirely through the Web Shell UI without touching
settings.json.Reviewer Test Plan
How to verify
cd packages/web-shell && npx vitest run client/components/channels/channel-platform.test.ts— both tests should pass.Evidence (Before & After)
N/A (non-TUI change; form rendering depends on daemon runtime)
Tested on
Environment (optional)
Unit tests only (
vitest).Risk & Scope
reasonFilter,allowedUsers,action_prompt_template) are not exposed in the form; they remainsettings.json-only.Linked Issues
Follow-up to #7862 (comment)
中文说明
本 PR 做了什么
为 GitHub 和 GitLab 频道插件添加
management描述符,使 Web Shell 频道管理 UI 能够配置它们。此前只有 DingTalk、WeCom、Feishu 可通过 Web Shell 管理,GitHub 和 GitLab 需要手动编辑settings.json。每个插件声明两个表单字段:
token(secret,必填)和baseUrl(string,可选),均支持环境变量解析。Web Shell 前端白名单扩展加入github和gitlab,对应单元测试已更新。为什么需要
来源:#7862 (comment) —— 用户应能完全通过 Web Shell UI 完成 GitHub 和 GitLab 频道的接入配置,无需手动编辑
settings.json。审阅者测试计划
如何验证
cd packages/web-shell && npx vitest run client/components/channels/channel-platform.test.ts—— 两个测试应通过。证据(前后对比)
N/A(非 TUI 变更;表单渲染依赖 daemon 运行时)
测试环境
运行环境(可选)
仅单元测试(
vitest)。风险与范围
reasonFilter、allowedUsers、action_prompt_template)未在表单中暴露,仍需通过settings.json配置。关联 Issue
跟进 #7862 (comment)