fix(serve): add missing SessionService import in session routes - #8145
fix(serve): add missing SessionService import in session routes#8145wenshao wants to merge 1 commit into
Conversation
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
yiliang114
left a comment
There was a problem hiding this comment.
LGTM. Single-line missing import fix, correctly placed in alphabetical order. No logic change.
|
Superseded by #8144, which takes a better approach by routing through createWorkspaceRuntimeSessionService instead of adding the direct import. |
|
Thanks for the PR! Template looks good ✓ Problem: observed build failure — Direction: aligned — this is a straightforward missing-import fix that unblocks Size: not applicable — single file in Approach: minimal and correct. The import is added to the existing Risk: no elevated risk signals. Moving on to code review. 🔍 中文说明感谢贡献! 模板完整 ✓ 问题:已观测到的构建失败—— 方向:对齐——这是一个简单的缺失导入修复,解除 规模:不适用——仅涉及 方案:最小且正确。导入按字母顺序添加到现有的 风险:无升级风险信号。 进入代码审查 🔍 — Qwen Code · qwen3.8-max-preview Reviewed at |
|
Code review: the diff is a single line — Independent proposal matched: I would have done exactly this — add the missing symbol to the existing import. One could also migrate the two Testing: N/A — build fix with no user-visible behavioral change. The oracle is
Key CI checks (ubuntu test suite, Serve A/B, Real daemon E2E) are still running. macOS/Windows tests and integration tests were skipped per CI configuration. No failures so far. 中文说明代码审查:diff 仅一行——在 独立方案匹配:我会做完全相同的修改。也可以将两处 测试:不适用——构建修复,无用户可见的行为变更。验证标准是 CI 状态:关键检查(ubuntu 测试套件、Serve A/B、Real daemon E2E)仍在运行中。macOS/Windows 测试和集成测试按 CI 配置跳过。目前无失败。 — Qwen Code · qwen3.8-max-preview Reviewed at |
|
Confidence: 5/5 — textbook missing-import fix; the build is broken on main and this one-line addition is the exact minimal repair. The PR does one thing and does it right: Note: the author has stated this PR is superseded by #8144 (still open). If #8144 lands first, this PR can be closed. If the build needs unblocking sooner, this one-line fix is safe to merge as-is. Approval deferred until CI lands green on 中文说明置信度:5/5 ——典型的缺失导入修复;main 分支构建已中断,这一行添加就是精确的最小修复。 PR 只做了一件事且做对了: 注意:作者已表示本 PR 被 #8144 取代(仍处于开放状态)。如果 #8144 先合并,本 PR 可以关闭。如果构建需要更快解除阻塞,这个单行修复可以安全合并。 审批推迟至 CI 在 — Qwen Code · qwen3.8-max-preview Reviewed at |
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
What this PR does
Adds the missing
SessionServiceimport to the daemon session routes. The class was referenced in two cleanup paths (generation-guard rejection and non-writable response) but was never imported, causing a TypeScript compilation failure.Why it's needed
npm run buildfails withTS2304: Cannot find name 'SessionService'in the CLI package, blocking all builds.Reviewer Test Plan
How to verify
Run
npm run buildfrom the project root. Before this fix it fails with twoTS2304errors; after the fix it completes successfully.Evidence (Before & After)
N/A (build fix, no UI change)
Tested on
Environment (optional)
npm run buildlocally.Risk & Scope
Linked Issues
N/A
中文说明
本 PR 做了什么
为守护进程会话路由补充了缺失的
SessionService导入。该类在两个清理路径(generation-guard 拒绝和响应不可写)中被引用,但从未被导入,导致 TypeScript 编译失败。为什么需要
npm run build因 CLI 包中的两个TS2304: Cannot find name 'SessionService'错误而失败,阻塞了所有构建。审阅者测试计划
如何验证
在项目根目录运行
npm run build。修复前会报两个TS2304错误;修复后构建成功完成。证据(修复前后)
N/A(构建修复,无 UI 变更)
测试环境
环境(可选)
本地
npm run build。风险与范围
关联 Issue
N/A