Repository navigation
feat(autofix): per-source feedback budget in Critical-only mode #8071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
601e1a4
fix(autofix): never defer maintainer feedback in Critical-only mode
508a598
feat(autofix): per-author feedback budget in Critical-only mode
714a896
Merge branch 'main' into fix/autofix-human-feedback-not-deferred
wenshao ddeb145
fix(autofix): fix deferred-feedback bash quoting and drop a dead jq b…
qwen-code-dev-bot 5bf5140
test(autofix): exercise census window-isolation guard with a stale-wi…
qwen-code-dev-bot 7d2c538
test(autofix): make census command-exclusion observable; surface cens…
qwen-code-dev-bot 80c53cb
fix(autofix): exclude never-deferrable feedback from the budget censu…
qwen-code-dev-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid finding — the census does count tagged items (a
**[Critical]**comment or aCHANGES_REQUESTEDreview) toward the per-author budget, while theCRITICAL_ONLY_HUMAN_BATCHESenv comment describes the budget as untagged batches with those tagged items as the escapes that cut through "past it". I confirmed the reproduction against the census jq. I'm leaving this thread open because the fix is a semantic call about what the brake should count, and the two resolutions have different behavioral consequences:CHANGES_REQUESTED/**[Critical]**reviews, Critical comments, replies-to-Critical, and CR-associated inline comments from the collected batches), plus a two-span fixture asserting a tagged-only author is NOT listed. This matches the documented design and this PR's intent to protect maintainer feedback from over-eager deferral, but it is a non-trivial change to a carefully-tested jq program and carries census regression risk.My recommendation is option 1 (it matches the documented intent), but only with maintainer eyes on the jq change. Which semantic do you want the budget to implement?
中文说明
发现成立——census 确实会把带标签的条目(
**[Critical]**评论或CHANGES_REQUESTEDreview)计入每位作者的预算,而CRITICAL_ONLY_HUMAN_BATCHES的环境变量注释把预算描述为未带标签的批次,并将这些带标签条目作为「超过预算后」仍可穿透的逃生口。我已对照 census 的 jq 复现了这一点。我把这个线程保持开放,因为修复方式是一个关于「刹车应统计什么」的语义抉择,两种方案有不同的行为后果:CHANGES_REQUESTED/**[Critical]**review、Critical 评论、对 Critical 的回复,以及关联 CR 的行内评论),并新增一个跨两个 span 的断言用例,验证仅提交带标签反馈的作者不会被列入。这符合文档化的设计,也符合本 PR 保护维护者反馈不被过度延后的意图,但它是对于一个经过充分测试的 jq 程序的非平凡改动,带有 census 回归风险。我的推荐是方案 1(它符合文档意图),但希望由维护者审视该 jq 改动。你希望预算实现哪种语义?