Skip to content
4 changes: 2 additions & 2 deletions integration-tests/sdk-typescript/tool-control.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1618,9 +1618,9 @@ describe('Tool Control Parameters (E2E)', () => {
const writeFileResults = findToolResults(messages, 'write_file');
expect(writeFileResults.length).toBeGreaterThan(0);

// Verify file was modified
// Verify file was modified (trim to tolerate trailing newline)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] This test is never executed by any PR-triggered CI job: integration-tests/ sits outside every npm workspace, and the workflows that collect it (e2e.yml full integration suite, release-sdk.yml) run only on push-to-main / nightly / SDK release — so this assertion change ships unverified at review time. Concrete cost: if the .trim() relaxation were wrong, no check on this PR would catch it; the first signal would be the post-merge E2E run or nightly regression. Procedural fix: run npm run test:integration:sdk:sandbox:none locally before merge and note the result in the PR.

中文说明

该测试不会被任何 PR 触发的 CI job 执行:integration-tests/ 不在任何 npm workspace 内,而收集它的 workflow(e2e.yml 完整集成套件、release-sdk.yml)只在 push 到 main / 每晚定时 / SDK 发布时运行——因此这个断言改动在评审时未经任何验证。具体代价:如果 .trim() 放宽有问题,本 PR 上没有任何检查能发现;第一个信号要等合并后的 E2E 运行或夜间回归。流程上的补救:合并前在本地运行 npm run test:integration:sdk:sandbox:none 并把结果记录在 PR 中。

— kimi-k3 via Qwen Code /review

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged — valid procedural note. This test is only exercised through the integration harness with a live model, so no PR-triggered CI job covers it. The post-merge E2E run remains the verification gate. Maintainers can run npm run test:integration:sdk:sandbox:none locally before merging if desired. No code change applicable.

中文说明

已知悉——有效的流程提醒。该测试仅通过集成测试套件配合真实模型运行,因此没有 PR 触发的 CI job 覆盖它。合并后的 E2E 运行仍是验证关卡。维护者可在合并前自行在本地运行 npm run test:integration:sdk:sandbox:none。无适用的代码改动。

const content = await helper.readFile('test.txt');
expect(content).toBe('updated');
expect(content.trim()).toBe('updated');
Comment thread
qwen-code-dev-bot marked this conversation as resolved.
Resolved
Comment thread
qwen-code-dev-bot marked this conversation as resolved.
Resolved
} finally {
await q.close();
}
Expand Down
Loading