Repository navigation
fix(test): trim trailing newline in tool-control asyncGenerator assertion #7950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5490cd5
fix(test): trim trailing newline in tool-control asyncGenerator asser…
qwen-code-dev-bot 3beff98
fix(test): use wording-agnostic assertion in tool-control asyncGenera…
qwen-code-dev-bot 46dabc6
fix(test): tighten asyncGenerator write assertion to toContain('updat…
qwen-code-dev-bot 597e6bd
Merge branch 'main' into fix/tool-control-trailing-newline
qwen-code-dev-bot 612ba4a
fix(test): use wording-agnostic not.toBe assertion in asyncGenerator …
qwen-code-ci-bot e29b8e7
Merge remote-tracking branch 'origin/main' into fix/tool-control-trai…
qwen-code-ci-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] This test is never executed by any PR-triggered CI job:
integration-tests/sits outside every npm workspace, and the workflows that collect it (e2e.ymlfull integration suite,release-sdk.yml) run only on push-to-main / nightly / SDK release — so this assertion change ships unverified at review time. Concrete cost: if the.trim()relaxation were wrong, no check on this PR would catch it; the first signal would be the post-merge E2E run or nightly regression. Procedural fix: runnpm run test:integration:sdk:sandbox:nonelocally before merge and note the result in the PR.中文说明
该测试不会被任何 PR 触发的 CI job 执行:
integration-tests/不在任何 npm workspace 内,而收集它的 workflow(e2e.yml完整集成套件、release-sdk.yml)只在 push 到 main / 每晚定时 / SDK 发布时运行——因此这个断言改动在评审时未经任何验证。具体代价:如果.trim()放宽有问题,本 PR 上没有任何检查能发现;第一个信号要等合并后的 E2E 运行或夜间回归。流程上的补救:合并前在本地运行npm run test:integration:sdk:sandbox:none并把结果记录在 PR 中。— kimi-k3 via Qwen Code /review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acknowledged — valid procedural note. This test is only exercised through the integration harness with a live model, so no PR-triggered CI job covers it. The post-merge E2E run remains the verification gate. Maintainers can run
npm run test:integration:sdk:sandbox:nonelocally before merging if desired. No code change applicable.中文说明
已知悉——有效的流程提醒。该测试仅通过集成测试套件配合真实模型运行,因此没有 PR 触发的 CI job 覆盖它。合并后的 E2E 运行仍是验证关卡。维护者可在合并前自行在本地运行
npm run test:integration:sdk:sandbox:none。无适用的代码改动。