-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(web-shell): add composer footer renderer #7856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion]
CustomComposerFooteris rendered without a shell-owned wrapper div, whileCustomComposerHeader(line 8459) is wrapped in<div className={styles.composerHeader}>which providesmargin-bottom: 8px. This creates a spacing asymmetry — hosts providing both renderers see 8px above the composer (shell-provided) but 0px below it. — Concrete cost: every host consumer must independently discover and addmargin-topto their footer renderer to achieve symmetric spacing.中文说明
[Suggestion]
CustomComposerFooter渲染时没有 shell 提供的包裹 div,而CustomComposerHeader(第 8459 行)被包裹在<div className={styles.composerHeader}>中(提供margin-bottom: 8px)。这导致间距不对称——同时提供两个渲染器的宿主会看到输入框上方有 8px 间距(shell 提供),但下方为 0px。—— 具体成本:每个宿主消费者都需要自行发现并在 footer 渲染器中添加margin-top以实现对称间距。— qwen3.7-max via Qwen Code /review