-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(core): add full-resolution image zoom tool #7809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f451c23
feat(core): add full-resolution image zoom tool
qqqys 57fd743
chore(vscode): refresh third-party notices
qqqys c6b07eb
fix(ui): satisfy zoom image display drift checks
qqqys d3227c5
fix(web-shell): translate zoom image tool
qqqys c9e0988
fix(core): wire sharp into packaging and load it lazily (#7809)
573b0d9
fix(core): gate zoom_image at execute time and cap tiny-crop upscale …
9cccf54
fix(core): emit zoom_image file telemetry and cover guard branches (#…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2025 Qwen | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import path from 'node:path'; | ||
| import type { Config } from '../config/config.js'; | ||
| import { Storage } from '../config/storage.js'; | ||
| import { isAnyAutoMemPath } from '../memory/paths.js'; | ||
| import type { PermissionDecision } from '../permissions/types.js'; | ||
| import { isSubpaths } from '../utils/paths.js'; | ||
|
|
||
| export function getFileReadDefaultPermission( | ||
| config: Config, | ||
| requestedPath: string, | ||
| ): PermissionDecision { | ||
| const filePath = path.resolve(requestedPath); | ||
| const workspaceContext = config.getWorkspaceContext(); | ||
|
|
||
| // SYNC: Keep these base roots and the auto-memory check below aligned with | ||
| // AcpAgent.buildAcpLocalReadRoots' mirrored ReadFileTool group. ACP may | ||
| // append fallback-only roots after that group. | ||
| const allowedRoots = [ | ||
| config.storage.getProjectTempDir(), | ||
| // Background subagent transcripts live under <projectDir>/subagents/ and | ||
| // are advertised to the model as polling targets via read_file. | ||
| path.join(config.storage.getProjectDir(), 'subagents'), | ||
| Storage.getGlobalTempDir(), | ||
| ...config.storage.getUserSkillsDirs(), | ||
| Storage.getUserExtensionsDir(), | ||
| // Approved plans are persisted here (default ~/.qwen/plans, outside | ||
| // the workspace) and after approval nothing re-injects the plan text, | ||
| // so the saved file is the model's only recovery route — reading it | ||
| // back must not stall on a confirmation prompt. The dir holds only | ||
| // session plan files, never credentials or settings. | ||
| config.getPlansDir(), | ||
| ]; | ||
|
|
||
| if ( | ||
| workspaceContext.isPathWithinWorkspace(filePath) || | ||
| isSubpaths(allowedRoots, filePath) || | ||
| // isAnyAutoMemPath narrows to the managed auto-memory roots | ||
| // (per-project + user-level under ~/.qwen/memories/) — never the | ||
| // broad getMemoryBaseDir() — to avoid exposing sensitive ~/.qwen | ||
| // files such as settings.json or OAuth credentials. | ||
| isAnyAutoMemPath(filePath, config.getTargetDir()) | ||
| ) { | ||
| return 'allow'; | ||
| } | ||
| return 'ask'; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.