Skip to content

test(web-shell): capture the git-mode new-branch sub-state in the visuals suite #7672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 3 commits into from
Jul 25, 2026
Merged

test(web-shell): capture the git-mode new-branch sub-state in the visuals suite #7672

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c5021f
test(web-shell): capture the git-mode new-branch sub-state in the vis…
Jul 24, 2026
ad804e7
test(web-shell): strengthen git-mode branch assertion and trim commen…
qwen-code-ci-bot Jul 24, 2026
d4f3975
test(web-shell): harden git-mode branch capture into a real #7668 guard
qwen-code-ci-bot Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions packages/web-shell/client/e2e/visuals/screenshots.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,16 +423,31 @@ for (const theme of THEMES) {
// Open: the three-mode popover (current / new branch / worktree). Assert
// an option is visible (not just the chip's aria-label) so a regression
// that fails to open the popover fails here, not only in the visually
// reviewed screenshot. The branch-name sub-state is intentionally not
// captured: its input autoFocuses, and the popover then dismisses on the
// idle frame captureScreenshot waits for — so it can't be shot stably
// through this pipeline (the functional web-shell.git-mode.spec.ts drives
// that path). The chip + open popover already show the new UI head-only.
// reviewed screenshot.
await chip.click();
await expect(
page.getByText('Current branch', { exact: true }),
).toBeVisible();
await captureScreenshot(page, `git-mode-popover-${theme}`);

// #7668 keeps this sub-state open. Match the option by role — its label
// spans a name + description span, so getByText is ambiguous.
const popover = page.locator('[data-slot="popover-content"]');
await popover.getByRole('radio', { name: /New branch/ }).click();
const branchInput = page.locator('[data-testid="git-mode-branch-input"]');
await expect(branchInput).toBeVisible();
await branchInput.fill('feat/my-feature');
// Regression guard for #7668: the input flashes visible on click, but the
// pre-fix dismissal landed ~100ms later, so an immediate assertion still
// passed. Settle past that window and re-assert, so a re-dismissal hard-fails
// here — mirroring the functional web-shell.git-mode.spec.ts.
await page.waitForTimeout(300);
await expect(popover).toBeVisible();
await expect(branchInput).toBeVisible();
await expect(
page.locator('[data-testid="git-mode-confirm-branch"]'),
).toBeEnabled();
await captureScreenshot(page, `git-mode-branch-${theme}`);
});

test(`slash menu`, async ({ page }, testInfo) => {
Expand Down
Loading