fix(web-shell): show full session names on hover - #7662
Merged
Conversation
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Collaborator
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Collaborator
|
Thanks for the PR! Template looks good ✓ Problem: Real UX limitation — truncated session names in the Web Shell sidebar can't be read in full. This is self-evident and observable by anyone using the sidebar with long session names. No linked issue, but the problem doesn't need one. Direction: Aligned. Native Size: Not applicable — no core paths touched. All changes are in Approach: The scope feels right — three Moving on to code review. 🔍 中文说明感谢贡献！ 模板完整 ✓ 问题：真实的 UX 局限——Web Shell 侧边栏中被截断的会话名称无法查看完整内容。这对任何使用长会话名称的用户来说都是显而易见的。虽然没有关联 issue，但这个问题不需要 issue 来证明。 方向：对齐。原生 规模：不适用——未触及核心路径。所有改动都在 方案：范围合理——在现有的会话名称 span（活跃、归档、只读）上添加三个 进入代码审查 🔍 — Qwen Code · qwen3.8-max-preview Reviewed at |
Collaborator
Code ReviewIndependent proposal: I'd add the HTML The PR does exactly this. The diff is three Tests verify the No findings. TestingCI results at reviewed commit
Not verified: visual appearance of the native tooltip (browser/OS-controlled, no custom styling to validate). 中文说明代码审查独立方案：在侧边栏中每个会话名称 PR 正是这样做的。diff 是在现有 span 上添加三个 测试验证了 无发现。 测试审查时 commit
未验证：原生 tooltip 的视觉外观（由浏览器/操作系统控制，无自定义样式需验证）。 — Qwen Code · qwen3.8-max-preview Reviewed at |
Collaborator
|
Confidence: 5/5 — Clean across every stage; would merge without hesitation. This is what a good PR looks like: a real, observable problem (truncated session names you can't read), solved with the minimum possible code (three 中文说明置信度：5/5 —— 每个阶段都很干净；毫不犹豫地合并。 这是一个优秀 PR 的典范：一个真实、可观察的问题（被截断的会话名称无法阅读），用最少的代码解决（三个 — Qwen Code · qwen3.8-max-preview Reviewed at |
qwen-code-ci-bot
previously approved these changes
Jul 24, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
Collaborator
🖼️ web-shell visual previewRendered against a mock daemon (no real backend): the PR base vs this PR head Screenshots · before / afterℹ️ No screenshot changed against the PR base — but this PR edits 2 render-shaping files:
Either the change has no visual effect (logic, plumbing, a state the scenarios never reach), or no scenario renders this UI — in which case the preview cannot see it, and an empty result is a coverage gap rather than a clean bill of health. To make it visible, add a scenario to Full-resolution recordings (.webm) are attached to the workflow run. — Qwen Code · web-shell visuals |
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed — no blockers. Suggestions are inline.
— qwen3.7-max via Qwen Code /review
Collaborator
Author
✅ Local verification — merge referenceBuilt and verified PR head TL;DR: the PR adds
Automated checks (head
|
| Check | Command | Result |
|---|---|---|
| Focused unit tests | vitest run on the 2 changed test files |
19/19 pass (WebShellSidebar.collapse-persist 10 + WorkspaceSection 9) |
| A/B discrimination | base source overlaid, PR tests kept | 2 fail on base, 19/19 on PR — the 2 new tooltip tests are discriminating |
| TypeScript | tsc -p tsconfig.json --noEmit |
exit 0 |
| Prettier | prettier --check (4 changed files) |
clean |
| ESLint | eslint (4 changed files) |
exit 0 |
A/B — the new tests actually pin the fix
Overlaying the base version of the two source files (git show 8c1bf64~1:<file>) while keeping the PR's tests removes the title attribute. Result:
× WebShellSidebar … > shows the complete session name in a native tooltip
× WorkspaceSection label > shows the complete read-only session name in a native tooltip
Test Files 2 failed (2)
Tests 2 failed | 17 passed (19)
Both fail because their [title="…"] selectors resolve to null. Restoring the PR source → 19/19 green. So the two added tests are not vacuous — they lock in exactly the behavior this PR introduces.
Live DOM proof (real browser render, Playwright + mock daemon)
Rendered the actual sidebar with long session names and read each session‑name span from the live DOM:
| Span | Source | title attr |
Visually truncated |
|---|---|---|---|
.sessionText (active) |
WebShellSidebar.tsx:2971 |
present ✓ | yes — scrollWidth 404 > clientWidth 164 |
.sessionText (archived) |
WebShellSidebar.tsx:2811 |
present ✓ | same span type · parallel edit |
.sessionName (read‑only) |
WorkspaceSection.tsx:447 |
present ✓ | yes — scrollWidth 403 > clientWidth 184 |
Each long name stays clipped to one line with an ellipsis (layout preserved) and now carries the complete label on title.
| Dark | Light |
|---|---|
 |
 |
The top section is the trusted workspace (active rows, .sessionText); the danger-zone-workspace section is untrusted → read‑only rows (.sessionName). Every row is truncated with an ellipsis, and each carries its full name on title.
On the native tooltip / visual‑preview bot: the tooltip itself is drawn by the browser/OS on hover, so it never appears in a page screenshot — which is exactly why the automated
web-shell visual previewbot reported "no screenshot changed" here. That is expected for atitle‑only change, not a coverage gap: the mechanism is thetitleattribute + the preserved ellipsis truncation shown above, both verified from the live DOM.
Verdict
Merge‑ready from a verification standpoint. Minimal, well‑tested, zero behavioral change to layout or session‑name generation; the only added surface is the native title tooltip. Matches the PR's own test plan (19 tests, typecheck, prettier). CI is green (Test · web‑shell E2E Smoke · visuals capture · triage 5/5).
🇨🇳 中文版本
✅ 本地验证 —— 合并参考
在独立 worktree 中基于 PR head 8c1bf64 执行了完整 npm ci（真实 workspace 构建，未走 symlink 捷径）并验证。所有检查通过，改动极小、风险低。
一句话总结： 该 PR 给三处会话名 span（活跃、归档、只读）加上了 title={label}，使浏览器原生 tooltip 在悬停时显示完整名称，同时保持原有单行省略号截断不变。19/19 聚焦测试通过；两个新增测试确实锁定了该修复（在 base 上会失败）；typecheck / prettier / eslint 均干净。
自动化检查（head 8c1bf64）
| 检查 | 命令 | 结果 |
|---|---|---|
| 聚焦单元测试 | 对 2 个改动测试文件跑 vitest run |
19/19 通过（WebShellSidebar.collapse-persist 10 + WorkspaceSection 9） |
| A/B 区分度 | 覆盖 base 源码、保留 PR 测试 | base 上 2 失败，PR 上 19/19 —— 两个新增 tooltip 测试具有区分度 |
| TypeScript | tsc -p tsconfig.json --noEmit |
exit 0 |
| Prettier | prettier --check（4 个改动文件） |
干净 |
| ESLint | eslint（4 个改动文件） |
exit 0 |
A/B —— 新增测试确实锁定了修复
用 base 版本（git show 8c1bf64~1:<file>）覆盖两个源文件、同时保留 PR 的测试后，title 属性消失，结果：两个新增 tooltip 测试因 [title="…"] 选择器返回 null 而恰好失败（2 失败 / 17 通过）；恢复 PR 源码后 → 19/19 全绿。说明这两个测试非空转，精确锁定了本 PR 引入的行为。
实时 DOM 证据（真实浏览器渲染，Playwright + mock daemon）
渲染真实侧边栏并从活动 DOM 读取每个会话名 span：
| Span | 位置 | title 属性 |
视觉截断 |
|---|---|---|---|
.sessionText（活跃） |
WebShellSidebar.tsx:2971 |
存在 ✓ | 是 —— scrollWidth 404 > clientWidth 164 |
.sessionText（归档） |
WebShellSidebar.tsx:2811 |
存在 ✓ | 同类 span · 平行改动 |
.sessionName（只读） |
WorkspaceSection.tsx:447 |
存在 ✓ | 是 —— scrollWidth 403 > clientWidth 184 |
每个长名称仍单行省略号截断（布局不变），并在 title 上携带完整标签。上方截图中，顶部区块是受信任 workspace（活跃行 .sessionText），danger-zone-workspace 区块为未信任 → 只读行 .sessionName。
关于原生 tooltip / 视觉预览机器人： tooltip 由浏览器/操作系统在悬停时绘制，不会出现在页面截图里 —— 这正是自动化
web-shell visual preview机器人在此报告"没有截图变化"的原因。对于仅改title的改动这是预期行为，而非覆盖缺口：其机制是title属性 + 保留的省略号截断，二者均已从活动 DOM 验证。
结论
从验证角度看可以合并。改动最小、测试充分，对布局与会话名生成逻辑零行为变更，唯一新增面是原生 title tooltip。与 PR 自述测试计划一致（19 项测试、typecheck、prettier）。CI 全绿（Test · web-shell E2E Smoke · visuals capture · triage 5/5）。
Verified locally by the maintainer on macOS · isolated worktree + real npm ci · screenshots rendered via Playwright against a mock daemon (no real backend).
Collaborator
Author
|
@qwen-code /takeover |
qwen-code-dev-bot
added
the
autofix/takeover
Collaborator
|
🤝 Takeover engaged: the autofix loop now manages this PR — it will address new review feedback and resolve base conflicts until the label is removed or the round cap is reached. Remove the 中文说明🤝 已接管：autofix 循环现在管理此 PR —— 将持续处理新的评审反馈与 base 冲突，直到移除标签或达到轮次上限。移除 |
Collaborator
|
🤖 Addressed the latest review feedback (round 1/100). What changed, and what I pushed back on: · 已处理最新评审反馈（第 1/100 轮）。改动内容与我反驳保留之处如下： Review feedback addressedInline comment [rc:3644809398] — Archived session tooltip test coverageClassification: Optional (Suggestion) Decision: Implemented. Change: Added a test case Issue-level comments
Verification
中文说明已处理的评审反馈行内评论 [rc:3644809398] — 归档会话 tooltip 测试覆盖分类： 可选（建议） 决定： 已实现。 变更： 在 Issue 级别评论
验证
Base-conflict check · 基分支冲突检查: no conflict with main. · 与 main 无冲突。 Re-review when you have a moment. After round 100 this bot stops and leaves the PR for a human. · 有空请复审；第 100 轮后本 bot 停止并将 PR 交给人工。 🧠 Handled by Qwen Code · model/模型 |
qwen-code-ci-bot
approved these changes
Jul 24, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅
— qwen3.7-max via Qwen Code /review
ytahdn
approved these changes
Jul 24, 2026
ytahdn
left a comment
ytahdn
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. 三处 session name 添加 title={label} native tooltip（active / archived / read-only workspace），截断时 hover 可见完整名称。测试覆盖 3 个场景。
— qwen3.7-plus via Qwen Code /review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a lightweight native tooltip to session names in the Web Shell sidebar, including active, archived, and read-only workspace session rows. Existing single-line truncation remains unchanged, while hovering the name exposes the complete label.
Why it's needed
Long session names are truncated to preserve the sidebar layout, but users currently have no direct way to read the complete name from the session row. A native tooltip provides that information without adding custom overlay state, positioning logic, or visual noise.
Reviewer Test Plan
How to verify
Open the Web Shell with a session whose display name is wider than the sidebar. Confirm the row remains truncated with an ellipsis, then hover the session name and verify the browser displays the complete label. Repeat for an archived session and a read-only session under an untrusted workspace. The focused unit tests passed with 19 tests, and the Web Shell TypeScript typecheck and Prettier checks passed.
Evidence (Before & After)
Before: Truncated session names could not be read in full directly from the sidebar row.
After: Hovering a session name displays its complete label through the browser's native tooltip while preserving the existing truncated layout.
Tested on
Environment (optional)
Local Vitest and TypeScript checks on macOS.
Risk & Scope
Linked Issues
None.
中文说明
这个 PR 做了什么
为 Web Shell 左侧栏中的会话名称增加轻量的浏览器原生 tooltip，覆盖活跃会话、归档会话和只读工作区会话。现有单行截断行为保持不变，鼠标悬停在名称上时可以查看完整标签。
为什么需要
较长的会话名称会被截断，以保持侧边栏布局稳定，但用户目前无法直接从会话行查看完整名称。使用浏览器原生 tooltip 可以补充完整信息，同时无需增加自定义浮层状态、定位逻辑或额外视觉干扰。
Reviewer 测试计划
如何验证
打开 Web Shell，并准备一个显示名称宽度超过侧边栏的会话。确认会话行仍使用省略号截断，然后将鼠标悬停在会话名称上，验证浏览器显示完整标签。对归档会话和未信任工作区下的只读会话重复验证。相关单元测试共 19 项均通过，Web Shell TypeScript 类型检查和 Prettier 检查也已通过。
前后效果证据
修改前：侧边栏中被截断的会话名称无法直接查看完整内容。
修改后：悬停会话名称时，浏览器原生 tooltip 会显示完整标签，同时保留现有的截断布局。
测试系统
环境（可选）
在 macOS 上运行本地 Vitest 和 TypeScript 检查。
风险与范围
关联 Issue
无。