Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .qwen/skills/autofix/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,15 @@ Read `git diff origin/<base>...HEAD` first, then `<workdir>/feedback.md`.

Classify every feedback point:

Address each the way AGENTS.md's Simplicity First and Comments rules demand:
the smallest change that resolves the point, no error handling for a condition
that cannot occur, no comment that restates the code. Review rounds ratchet
code UP — every round tends to add — so on each one also ask what the change
lets you REMOVE or shrink, not only what to add. A suggestion whose only effect
is more defense, configurability, or narration a senior engineer would call
overcomplicated is a Decline (not worth the diff growth), not an automatic
implement — satisfying a nit is never a reason to bloat the code.

- Required: correctness bug, broken build/test, security issue, or a
`CHANGES_REQUESTED` item naming a real defect. Verify it, then fix minimally.
- Optional: suggestion, nit, or hardening — including `**[Suggestion]**`
Expand All @@ -201,8 +210,11 @@ unnecessarily.
Finish with exactly one outcome:

- Made a change: re-read the full diff as a skeptical reviewer — confirm each
feedback point is actually addressed AND that the change introduces no new
defect. Then ACTUALLY RUN `npm run build`, `npm run typecheck`,
feedback point is actually addressed, that the change introduces no new
defect, AND that it added no bloat: no defense for an impossible case, no
comment that is not a non-obvious "why", nothing a senior engineer would call
overcomplicated (AGENTS.md Simplicity First). Cut it before you commit. Then
ACTUALLY RUN `npm run build`, `npm run typecheck`,
`npm run lint`, focused Vitest tests for the package(s) you touched, and
integration tests after `npm run bundle` when the touched behavior is only
exercised through the bundled CLI or integration harness (plus
Expand Down
6 changes: 6 additions & 0 deletions scripts/tests/qwen-autofix-workflow.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -3398,6 +3398,12 @@ describe('qwen-autofix workflow', () => {
expect(flat).toContain('## Verification');
expect(flat).toContain('command you ran and its result');
expect(flat).toContain('a bare "verified" is not acceptable');
// Simplicity First governs HOW findings are addressed against the additive
// ratchet of review rounds: the pre-commit self-audit rejects bloat, and a
// nit that would bloat the code is a decline, not an auto-implement.
expect(flat).toContain('Simplicity First');
expect(flat).toContain('added no bloat');
expect(flat).toContain('never a reason to bloat the code');
// The rationale is structural, not etiquette: the gate re-runs the same
// commands, so skipping them only moves the rejection later. Pin that
// framing so the requirement is not softened back into "please verify".
Expand Down
Loading