-
Notifications
You must be signed in to change notification settings - Fork 3k
docs: refresh subagent lifecycle guidance #7624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] Interactive forks without
run_in_background: truedefault to the foreground path and return only a placeholder — the fork's actual result is never delivered to the parent conversation. The docs here cover "background runs" (completion notification) and "foreground regular subagents" (inline), but omit the interactive fork case.The same gap exists in two other places this PR touches:
agent.ts:794has the missing guidance: "Set to true for an interactive fork to receive its completion notification."docs/developers/tools/task.mdline 17 describesrun_in_backgroundfor "top-level regular agents" and "headless forks" but omits interactive forks.Failure scenario: A user launches
agent({subagent_type: "fork", prompt: "..."})in an interactive session withoutrun_in_background: true. The code routes this to the foreground fork path (agent.ts:2463–2471), returnsFORK_PLACEHOLDER_RESULT, and the fork's actual result is never delivered.— qwen3.7-max via Qwen Code /review