-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(core): add configurable image generation models #7607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6cc1d42
cef8245
ddd5b57
77e4d27
c68f725
af2c513
49ff8d3
0311361
a3cff29
a08ebeb
9766191
8cca31a
e409dde
c411855
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1309,6 +1309,17 @@ const SETTINGS_SCHEMA = { | |
| showInDialog: true, | ||
| }, | ||
|
|
||
| imageModel: { | ||
| type: 'string', | ||
| label: 'Image Model', | ||
| category: 'Model', | ||
| requiresRestart: false, | ||
|
Comment on lines
+1312
to
+1316
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Critical] This declares direct — Codex GPT-5 via Qwen Code /review |
||
| default: '', | ||
| description: | ||
| 'Model used by the built-in image_gen tool. Set with /model --image. The selected model must be marked imageOnly in modelProviders.', | ||
| showInDialog: false, | ||
| }, | ||
|
|
||
| visionBridgeTimeoutMs: { | ||
| type: 'integer', | ||
| label: 'Vision Bridge Timeout (ms)', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Critical] Settings files are not guaranteed to be schema-validated on this load path, so a truthy non-string
imageModelis forwarded into parsing code that calls string methods and crashes CLI initialization. Type-check this value before passing it toConfig(and treat invalid values as unset or a configuration error).— Codex GPT-5 via Qwen Code /review