Skip to content

test(core): pin the archived-copy usage salvage in the conflict deletion test #7604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 1 commit into from
Jul 24, 2026
Merged

test(core): pin the archived-copy usage salvage in the conflict deletion test #7604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/core/src/services/sessionService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1606,6 +1606,15 @@ describe('SessionService', () => {
expect(unlinkSyncSpy).toHaveBeenCalledWith(
expect.stringContaining(`/chats/archive/${sessionIdA}.jsonl`),
);
// #7425 review follow-up: the archived copy's usage must be salvaged
// before deletion too — with a telemetry-less fresh active copy it is
// the only holder of the session's history. Pin the call so removing
// the "redundant-looking" archived salvage fails this test.
expect(
vi.mocked(persistUsageBeforeTranscriptDeletion),
).toHaveBeenCalledWith(
expect.stringContaining(`/chats/archive/${sessionIdA}.jsonl`),
);
});
});

Expand Down
Loading