Skip to content

fix: validate resolved npm path ends with .js before returning #7591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rkfshakti wants to merge 3 commits into from
Closed

fix: validate resolved npm path ends with .js before returning #7591

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3790b7a
fix: validate resolved npm path ends with .js before returning
rkfshakti Jul 23, 2026
ba750b2
Merge branch 'main' into fix/get-npm-cli-path-mise-wrapper
rkfshakti Jul 23, 2026
b2c53d7
Merge branch 'main' into fix/get-npm-cli-path-mise-wrapper
rkfshakti Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions packages/cli/src/utils/installationInfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,28 @@ export function getNpmCliPath(
// instead of throwing synchronously — getNpmCliPath is called from a
// non-async site (handleAutoUpdate), and a returned best-effort path lets the
// downstream spawn surface any failure through its 'error' handler.
//
// Some Node version managers (mise, asdf, proto) replace bin/npm with a
// non-JS wrapper script (e.g. a bash shim). fs.realpathSync succeeds on
// these (the file exists), but spawning `node /path/to/bash-wrapper` fails
// with a SyntaxError. Validate the resolved path ends with ".js" before
// returning it; otherwise fall back to the conventional path.
const adjacentNpm = path.join(path.dirname(nodePath), 'npm');
try {
return fs.realpathSync(adjacentNpm);
const resolved = fs.realpathSync(adjacentNpm);
if (resolved.endsWith('.js')) return resolved;
} catch {
return path.join(
path.dirname(nodePath),
'..',
'lib',
'node_modules',
'npm',
'bin',
'npm-cli.js',
);
// Fall through to the conventional path below.
}
return path.join(
path.dirname(nodePath),
'..',
'lib',
'node_modules',
'npm',
'bin',
'npm-cli.js',
);
}

const debugLogger = createDebugLogger('INSTALLATION_INFO');
Expand Down