-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(sdk-python): validate max_tool_calls and max_subagent_depth as integers #7548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wenshao
merged 3 commits into
QwenLM:main
from
chinesepowered:fix/py-int-option-validation
Jul 23, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] This predicate duplicates logic already present in
_as_optional_intintypes.py(line 258:isinstance(raw, bool) or not isinstance(raw, int)), which guards the same three fields during JSON deserialization. If a future change adjusts what counts as a valid integer (e.g., acceptingnumpy.int64), both sites must be updated — missing one creates inconsistent behavior between the programmatic and deserialization paths.Consider consolidating: move
_is_inttotypes.py(or import it there) and refactor_as_optional_intto use it.— qwen3.7-max via Qwen Code /review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch that the two sites exist — I'd rather not consolidate them here, though, because they aren't quite the same check and merging them would change behavior beyond this fix.
_as_optional_intis a deserialization coercion: it runs on untrustedMappingdata inQueryOptions.from_dictand raisesTypeError._is_intis a predicate used byvalidate_query_options, which raisesValidationErrorand composes with a range test in the same condition. Having_as_optional_intcall_is_intwould meantypes.pyimporting fromvalidation.py, which importsQueryOptionsfromtypes.py— a cycle. The other direction (moving_is_intintotypes.pyand importing it back) works, but it makes a private helper of the type module part of the validation module's contract for a two-line predicate.The divergence risk you describe is real but bounded: if
numpy.int64ever needed accepting, the deserialization path would have to change anyway, since_as_optional_intalso callsint(raw)on the result and the two paths have different error types. I'd rather leave both explicit and obvious than share a helper across that boundary — and if the project would prefer them unified, that's a refactor worth its own PR rather than folding into a validation fix.