Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -594,4 +594,72 @@ describe('useWebViewMessages', () => {
'/tmp/insight-report.html',
);
});

it('inserts resolved image attachments as raw absolute references', () => {
const rendered = renderHookHarness();
root = rendered.root;
container = rendered.container;

const input = document.createElement('div');
(
rendered.handlers.inputFieldRef as { current: HTMLDivElement | null }
).current = input;

act(() => {
window.dispatchEvent(
new MessageEvent('message', {
data: {
type: 'fileAttached',
data: {
id: 'file-1',
type: 'file',
name: 'screen shot.png',
value: 'C:\\Users\\Me\\Pictures\\screen shot.png',
},
},
}),
);
});

expect(rendered.handlers.fileContext.addFileReference).toHaveBeenCalledWith(
'screen shot.png',
'C:\\Users\\Me\\Pictures\\screen shot.png',
);
expect(input.textContent).toBe(
'@C:\\Users\\Me\\Pictures\\screen shot.png ',
);
expect(rendered.handlers.setInputText).toHaveBeenCalledWith(
'@C:\\Users\\Me\\Pictures\\screen shot.png ',
);
});

it('keeps non-image attachments as file-name references', () => {
const rendered = renderHookHarness();
root = rendered.root;
container = rendered.container;

const input = document.createElement('div');
(
rendered.handlers.inputFieldRef as { current: HTMLDivElement | null }
).current = input;

act(() => {
window.dispatchEvent(
new MessageEvent('message', {
data: {
type: 'fileAttached',
data: {
id: 'file-1',
type: 'file',
name: 'notes.txt',
value: 'C:\\Users\\Me\\Documents\\notes.txt',
},
},
}),
);
});

expect(input.textContent).toBe('@notes.txt ');
expect(rendered.handlers.setInputText).toHaveBeenCalledWith('@notes.txt ');
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
type WebViewMessage,
type WebViewMessageBase,
} from './useImage.js';
import { isDisplayableImagePath } from '../../utils/imageSupport.js';

const FORCE_CLEAR_STREAM_END_REASONS = new Set([
'user_cancelled',
Expand Down Expand Up @@ -1296,9 +1297,12 @@ export const useWebViewMessages = ({

if (inputFieldRef.current) {
const currentText = inputFieldRef.current.textContent || '';
const referenceText = isDisplayableImagePath(attachment.value)
? attachment.value
: attachment.name;
const newText = currentText
? `${currentText} @${attachment.name} `
: `@${attachment.name} `;
? `${currentText} @${referenceText} `
: `@${referenceText} `;
inputFieldRef.current.textContent = newText;
setInputText(newText);

Expand Down
Loading