fix(release): exclude mobile-mcp from core version bump - #7474
Merged
Conversation
mobile-mcp has its own release cadence and CODEOWNER (@LaZzyMan). Bumping it in every core release PR forces an extra approval from LaZzyMan even though the change is a routine version bump. Exclude @qwen-code/mobile-mcp from the workspacesToExclude list in scripts/version.js, following the same pattern as @qwen-code/sdk. Closes #7462
Collaborator
|
Thanks for the PR! Template: headings differ from the template (Summary/Why/What changed/Testing vs the full template structure), but for a 2-line build script change the content covers what matters — what, why, how to verify, and a linked issue. Not blocking on this. Problem: real and observed. Every core release PR (e.g. #7461) bumps Direction: clearly aligned — this reduces release friction by excluding an independently-versioned package from the core bump, following the exact same pattern already used for Size: not applicable — Approach: the scope is exactly right. One array entry, one comment update. Can't get more minimal than this. Moving on to code review. 🔍 中文说明感谢贡献！ 模板：标题格式与模板不同（Summary/Why/What changed/Testing vs 完整模板结构），但对于一个 2 行的构建脚本改动，内容覆盖了关键信息——做了什么、为什么、如何验证、关联 issue。不因此阻塞。 问题：真实且已观测到。每次核心发布 PR（如 #7461）都会 bump 方向：完全对齐——通过排除独立版本管理的包来减少发布摩擦，与 规模：不适用—— 方案：范围完全正确。一个数组条目，一行注释更新。不可能更精简了。 进入代码审查 🔍 — Qwen Code · qwen3.7-max Reviewed at |
Collaborator
Code ReviewIndependent proposal: given "mobile-mcp gets version-bumped during core releases, triggering unnecessary CODEOWNERS approval", I would add Diff review: the change is two lines — one comment update and one array entry. It follows the established pattern precisely. No correctness issues, no security concerns, no convention violations. Nothing to flag. Real-Scenario TestingVerified the workspace filtering logic before and after the change using Before (main)After (PR #7474)mobile-mcp correctly excluded from the version bump. sdk exclusion unchanged. 17 workspaces still versioned as expected. 中文说明代码审查独立方案： 针对"mobile-mcp 在核心发布时被版本 bump，触发不必要的 CODEOWNERS 审批"这个问题，我的方案是在 Diff 审查： 改动两行——一行注释更新，一个数组条目。完全遵循已有模式。无正确性问题、无安全隐患、无规范违反。无需标记。 实际场景测试使用 改动前（main）：mobile-mcp 会被版本 bump（versioned: true），18 个工作区参与版本管理。 — Qwen Code · qwen3.7-max Reviewed at |
Collaborator
|
Confidence: 5/5 — clean, minimal, follows the existing pattern exactly, solves a real recurring release friction. This is the kind of PR that's easy to evaluate: the problem is concrete (every release PR needs an extra CODEOWNERS approval for a version-number-only change), the fix is one array entry following an established pattern, and the before/after confirms it works. No reservations. 中文说明置信度：5/5 — 干净、精简、完全遵循已有模式，解决了一个真实且反复出现的发布摩擦。 这个 PR 很容易评估：问题具体（每次发布 PR 都需要额外的 CODEOWNERS 审批，仅仅因为版本号改动），修复是一个数组条目、遵循已有模式，before/after 测试确认有效。没有保留意见。 — Qwen Code · qwen3.7-max Reviewed at |
qwen-code-ci-bot
approved these changes
Jul 22, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
qwen-code-ci-bot
approved these changes
Jul 22, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅
— qwen3.7-max via Qwen Code /review
ytahdn
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Excludes
@qwen-code/mobile-mcpfrom the core release version bump inscripts/version.js, following the same pattern already used for@qwen-code/sdk. After this change, runningnpm run versionwill no longer touchpackages/mobile-mcp/package.json.Why it's needed
Every core release PR (e.g. #7461) bumps all workspace
package.jsonversions, includingpackages/mobile-mcp/package.json. Since CODEOWNERS assigns/packages/mobile-mcp/to @LaZzyMan only, every routine release PR requires an extra approval from LaZzyMan even though the mobile-mcp change is just a version number bump. This adds unnecessary review overhead. mobile-mcp has its own release cadence and should be versioned independently, like the SDK.Reviewer Test Plan
How to verify
npm run version patch --no-git-tag-versionon this branchpackages/mobile-mcp/package.jsonversion is unchangednpm version patch --workspace @qwen-code/mobile-mcp --no-git-tag-versionEvidence (Before & After)
N/A — non-UI change (build script modification).
Tested on
Environment (optional)
N/A — only affects the
npm run versionscript.Risk & Scope
Linked Issues
Closes #7462
中文说明
这个 PR 做了什么
在
scripts/version.js中将@qwen-code/mobile-mcp加入workspacesToExclude，使 core 发版时不再自动 bump mobile-mcp 的版本号。与@qwen-code/sdk的处理方式一致。为什么需要
每次 core 发版 PR（如 #7461）会批量 bump 所有 workspace 的
package.json版本号，包括packages/mobile-mcp/package.json。由于 CODEOWNERS 将/packages/mobile-mcp/分配给 @LaZzyMan，每次常规发版都需要 LaZzyMan 额外审批，即使 mobile-mcp 的改动只是版本号。mobile-mcp 有自己的发布节奏，应该像 SDK 一样独立管理版本。审查测试计划
如何验证
npm run version patch --no-git-tag-versionpackages/mobile-mcp/package.json版本号未变npm version patch --workspace @qwen-code/mobile-mcp --no-git-tag-version证据（前后对比）
N/A — 非 UI 变更（构建脚本修改）。
测试平台
环境（可选）
N/A — 仅影响
npm run version脚本。风险与范围
关联 Issue
Closes #7462