Repository navigation
fix(cli): soften update-check failure UX — warning instead of error, raise timeout to 5s #7409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yiliang114
merged 2 commits into
QwenLM:main
from
ComplexSimply:fix/update-check-timeout-ux-7049
Jul 21, 2026
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ import { vi, describe, it, expect, beforeEach } from 'vitest'; | |
| import { | ||
| checkForUpdates, | ||
| checkForUpdatesDetailed, | ||
| classifyUpdateCheckError, | ||
| fetchGlobalNpmUpdateInfo, | ||
| FETCH_TIMEOUT_MS, | ||
| isGlobalNpmInstallation, | ||
|
|
@@ -633,4 +634,46 @@ describe('checkForUpdates', () => { | |
| } | ||
| }); | ||
| }); | ||
|
|
||
| describe('timeout budget (#7049)', () => { | ||
| it('allows at least 5 seconds for slow registries', () => { | ||
| expect(FETCH_TIMEOUT_MS).toBeGreaterThanOrEqual(5000); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be |
||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('classifyUpdateCheckError', () => { | ||
| it('classifies UpdateCheckTimeoutError as timeout', () => { | ||
| expect(classifyUpdateCheckError(new UpdateCheckTimeoutError(5000))).toBe( | ||
| 'timeout', | ||
| ); | ||
| }); | ||
|
|
||
| it.each([ | ||
| 'ENOTFOUND', | ||
| 'ECONNREFUSED', | ||
| 'EAI_AGAIN', | ||
| 'ETIMEDOUT', | ||
| 'ENETUNREACH', | ||
| ])('classifies %s errors as offline', (code) => { | ||
| const error = new Error(`request failed`) as NodeJS.ErrnoException; | ||
| error.code = code; | ||
| expect(classifyUpdateCheckError(error)).toBe('offline'); | ||
| }); | ||
|
|
||
| it('classifies network codes embedded in the message as offline', () => { | ||
| // npm child-process failures surface the code inside stderr text only. | ||
| expect( | ||
| classifyUpdateCheckError( | ||
| new Error('npm error code ENOTFOUND\nnpm error network'), | ||
| ), | ||
| ).toBe('offline'); | ||
| }); | ||
|
|
||
| it('classifies other errors as registry', () => { | ||
| expect(classifyUpdateCheckError(new Error('404 Not Found'))).toBe( | ||
| 'registry', | ||
| ); | ||
| expect(classifyUpdateCheckError('not-an-error')).toBe('registry'); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The report in #7049 is about the non-blocking startup check. This changes the explicit
qwen updatefailure contract as well, and the same propagation appears in/updateand the relaunch path. Could we leave those paths unchanged in this PR and keep the change at the startup boundary?