ci: split model vars for autofix, triage, and review workflows - #7283
Merged
Conversation
wenshao
approved these changes
Jul 20, 2026
ytahdn
approved these changes
Jul 20, 2026
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Collaborator
|
Thanks for the PR! Template: PR uses custom headings (Motivation, Changes) rather than the standard template headings. Missing "Risk & Scope" and "Linked Issues" sections. For a change this small it's not blocking, but future PRs should follow the template more closely. Problem: Real and well-defined — three CI workflows (autofix, triage, review) sharing a single Direction: Aligned. Independent model configuration per workflow is clearly useful for tuning each pipeline separately. Size: Not applicable — only Approach: Scope is minimal and correct. Each workflow gets its own variable with a fallback to Moving on to code review. 🔍 中文说明感谢贡献！ 模板： PR 使用了自定义标题（Motivation、Changes）而非标准模板标题，缺少 "Risk & Scope" 和 "Linked Issues" 部分。对于这么小的改动不构成阻塞，但后续 PR 建议更严格地遵循模板。 问题： 真实且定义明确——三个 CI 工作流（autofix、triage、review）共用一个 方向： 对齐。为每个工作流独立配置模型显然有用。 规模： 不适用——仅修改 方案： 范围最小且正确。每个工作流获得自己的变量并回退到 进入代码审查 🔍 — Qwen Code · qwen3.7-max Reviewed at |
Collaborator
Code ReviewStraightforward variable substitution across two workflow files. The diff does exactly what the description promises:
The Both No correctness issues, no security concerns, no scope creep. Clean, minimal change. Real-Scenario TestingN/A — this is a CI workflow configuration change. The modified variables are consumed by GitHub Actions runners at workflow dispatch time, not by the CLI at runtime. There is no terminal-reproducible behavior change. Verification is post-merge: trigger an autofix run and a triage run, then confirm from the run logs that each picks up the intended model. 中文说明代码审查简单的变量替换，跨两个工作流文件。diff 完全符合描述：
无正确性问题、无安全隐患、无范围蔓延。干净、最小化的改动。 真实场景测试不适用——这是 CI 工作流配置变更。修改的变量在 GitHub Actions runner 调度工作流时消费，不在 CLI 运行时生效。没有可以在终端复现的行为变更。验证方式为合并后操作：触发一次 autofix 和一次 triage 运行，从运行日志确认各自使用了预期的模型。 — Qwen Code · qwen3.7-max Reviewed at |
Collaborator
|
Confidence: 5/5 — Clean across every stage; would merge without hesitation. This is a textbook minimal CI change. Eight variable substitutions across two workflow files, each adding a workflow-specific variable with a fallback to the shared one. The diff does exactly what the description says, nothing more. The problem is real and operationally relevant — the team already has the repo variables configured and just needs the workflows to reference them. The fallback pattern ensures nothing breaks if a variable is ever unset. Three human reviewers already approved. No concerns from any stage. Approving. 中文说明信心：5/5 — 各阶段均无问题，可以放心合并。 这是一个教科书式的 CI 最小改动。两个工作流文件中的八处变量替换，每处都添加工作流专用变量并回退到共享变量。diff 完全符合描述，没有多余内容。 问题是真实且运维相关的——团队已经配置好了 repo 变量，只需要工作流引用它们。回退模式确保变量未设置时不会出问题。 三位人类审查者已批准。各阶段均无顾虑。批准。 — Qwen Code · qwen3.7-max Reviewed at |
qwen-code-ci-bot
approved these changes
Jul 20, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
github-actions
Bot
added
the
skip-changelog-auto
Collaborator
|
Released in v0.20.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
All three CI workflows (autofix, triage, review) shared a single
QWEN_PR_REVIEW_MODELvariable, making it impossible to run different models for different tasks.Changes
qwen-autofix.yml: usevars.QWEN_AUTOFIX_MODEL || vars.QWEN_PR_REVIEW_MODELqwen-triage.yml: usevars.QWEN_TRIAGE_MODEL || vars.QWEN_PR_REVIEW_MODELqwen-code-pr-review.yml: unchanged, continues usingvars.QWEN_PR_REVIEW_MODELRepo variables already configured:
QWEN_AUTOFIX_MODEL= qwen3.8-max-previewQWEN_TRIAGE_MODEL= qwen3.8-max-previewQWEN_PR_REVIEW_MODEL= qwen3.7-maxHow to verify
After merge, trigger a review and an autofix run — confirm they pick up different models from the run logs.