feat(i18n): update catalan translaiton - #7253
Conversation
|
Thanks for the PR, and thanks for continuing to look after the Catalan translation! Template: the essentials are here — what it does, why, and a Tested-on table (macOS ✅, Linux ✅). The formal "Reviewer Test Plan / Risk & Scope / Linked Issues" sections are missing, but for a pure translation update those are effectively N/A, so I'm not going to block on it. Worth filling them in next time just to keep the template intact. Problem: real and observed by the translator themselves — a batch of strings were using the infinitive form ("Afegir context", "Mostrar/amagar") where Catalan UI convention wants the imperative ("Afegeix context", "Mostra/amaga"), plus keyboard-label fixes and a few accuracy improvements. This is accuracy work, not a hypothetical. Direction: aligned. i18n quality from the original Catalan author (#3643) is exactly the kind of contribution we want. CHANGELOG has no direct reference, but locale quality is squarely in scope. Size: not applicable — single locale file ( Approach: minimal and focused. Every change is a translation value; the only structural edits are two keys being deleted, which I checked — both ( Re-run note: 6 new commits landed since the last review (all applied suggestions from the /review bot). The incremental changes are small, focused translation fixes — reverting over-applied "Enter→Return" in keybinding name strings, fixing verb forms for imperative consistency, correcting plural agreement, and a more accurate "Add new" translation. All reviewed below. Moving on to code review. 🔍 中文说明感谢这个 PR,也感谢你持续维护加泰罗尼亚语翻译! 模板:核心内容都在——做了什么、为什么、以及 Tested-on 表格(macOS ✅、Linux ✅)。正式的 "Reviewer Test Plan / Risk & Scope / Linked Issues" 章节缺失,但对于纯翻译更新这些基本是 N/A,所以不因此拦截。下次顺手填上即可,保持模板完整。 问题:真实存在,由译者本人观察到——一批字符串使用了不定式形式("Afegir context"、"Mostrar/amagar"),而加泰罗尼亚语 UI 规范应使用命令式("Afegeix context"、"Mostra/amaga"),外加键盘标签修正和几处准确性改进。这是准确性工作,不是假设性问题。 方向:对齐。来自加泰罗尼亚语原作者(#3643)的 i18n 质量改进正是我们欢迎的贡献。CHANGELOG 无直接引用,但语言包质量完全在范围内。 规模:不适用——单个语言文件( 方案:最小且聚焦。每处改动都是翻译值;唯一的结构性编辑是删除了两个 key,我已核查——两者( Re-run 说明: 自上次审查以来新增了 6 个 commit(均为 /review 机器人的建议应用)。增量改动是小型、聚焦的翻译修正——恢复键绑定名称中被过度应用的 "Enter→Return"、修正动词形式以保持命令式一致性、修正复数一致性、以及更准确的 "Add new" 翻译。详见下方审查。 进入代码审查 🔍 — Qwen Code · qwen3.7-max Reviewed at |
Code reviewFor a translation update my independent bar is simple: keys must stay intact (so lookups don't break), values must be valid Catalan, the file must parse, and nothing should regress for live strings. The diff holds up against that:
No correctness, security, or convention concerns. Real-scenario testingDrove the PR code in tmux with The installed build (v0.19.10) also renders the Catalan TUI correctly, confirming the locale system works end-to-end: (The interactive dev build crashes on a pre-existing 中文说明代码审查对于翻译更新,我的独立标准很简单:key 必须保持不变(以免查询中断),值必须是有效加泰罗尼亚语,文件必须可解析,且活跃字符串不应回归。 diff 符合这些标准:
无正确性、安全性或约定方面的问题。 真实场景测试在 tmux 中以 — Qwen Code · qwen3.7-max Reviewed at |
|
Confidence: 5/5 — clean across every stage; would merge without hesitation. This is exactly what a good translation PR looks like. The author is the original Catalan translator, the changes are a focused batch of accuracy fixes (infinitive → imperative, the correct Catalan UI convention), and nothing else creeps in. The 6 new commits since the last review are all applied suggestions from the /review bot — I checked each one and they're all sensible: reverting an over-applied "Enter→Return" in keybinding labels, fixing verb forms, plural agreement, and a more accurate "Add new" translation. My only real check was the two deleted keys — I wanted to be sure they weren't live strings going untranslated — and both turned out to be dead entries that File parses, 31/31 i18n tests pass, and the locale renders correctly in both headless and interactive TUI modes. The interactive dev build has a pre-existing LGTM — approving. ✅ 中文说明置信度:5/5 —— 每个阶段都干净;毫不犹豫地合并。 这正是优秀翻译 PR 的样子。作者是加泰罗尼亚语原作者,改动是一批聚焦的准确性修正(不定式 → 命令式,加泰罗尼亚语 UI 的正确约定),没有夹带其他内容。自上次审查以来的 6 个新 commit 均为 /review 机器人建议的应用——逐一核查后均合理:恢复键绑定标签中被过度应用的 "Enter→Return"、修正动词形式、复数一致性、以及更准确的 "Add new" 翻译。 我唯一认真核查的是删除的两个 key——想确认它们不是仍在使用的字符串被漏译——结果两者都是死条目,因此删除是加分项而非损失。 文件可解析,31/31 i18n 测试通过,语言包在 headless 和交互式 TUI 模式下均正确渲染。交互式 dev 构建有预存的 LGTM —— 批准。✅ — Qwen Code · qwen3.7-max Reviewed at |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
Reviewed — no blockers. Suggestions are inline.
— qwen3.8-max-preview via Qwen Code /review
Co-authored-by: qwen-code-ci-bot <qwen-code-ci@service.alibaba.com>
Co-authored-by: qwen-code-ci-bot <qwen-code-ci@service.alibaba.com>
Co-authored-by: qwen-code-ci-bot <qwen-code-ci@service.alibaba.com>
Co-authored-by: qwen-code-ci-bot <qwen-code-ci@service.alibaba.com>
Co-authored-by: qwen-code-ci-bot <qwen-code-ci@service.alibaba.com>
Co-authored-by: qwen-code-ci-bot <qwen-code-ci@service.alibaba.com>
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
— qwen3.8-max-preview via Qwen Code /review
|
@qwen-code /triage |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
|
Released in v0.20.1. |
What this PR does
Why it's needed
A more complete and accurate translation
Tested on