fix(vscode): avoid regenerating notices during install - #7249
Closed
yiliang114 wants to merge 1 commit into
Closed
Conversation
yiliang114
force-pushed
the
cx/fix-vscode-notices-completeness
branch
from
July 20, 2026 17:06
b4a9d3d to
2431596
Compare
Contributor
|
Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. 中文请勿对活跃的 PR 执行 rebase 或 force-push,因为这会使已有的评审评论失效。另外,供日后参考:作为集成流程的一部分,机器人始终会自动将所有改动压缩(squash)为单个提交。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Stops normal dependency installation from regenerating the tracked VS Code companion notices. Notice generation remains explicit at the two points that need it: CI validation and VSIX packaging.
Why it's needed
The companion workspace's
preparescript ran duringnpm ci, so a normal dependency install could rewriteNOTICES.txtand leave an unrelated working-tree change. Removing that install-time hook keeps installs and ordinary builds clean without allowing stale notices to merge or ship.Reviewer Test Plan
How to verify
From a clean checkout, install dependencies and run an ordinary build. Confirm that
NOTICES.txtis unchanged. Then package the VS Code companion and confirm that prepackage explicitly generates notices, the generated file still matches the tracked copy, and the VSIX contains it. Dependency changes that require a notices update should continue to fail the existing CI drift check until the regenerated file is committed.Evidence (Before & After)
N/A (non-UI lifecycle change).
Tested on
Environment (optional)
macOS with Node.js 22.22.0. Verified a clean
npm ciincluding the full root build, companion lint/typecheck/build, explicit notice regeneration with no drift, and a complete VSIX package through the realnpm run packagelifecycle.Risk & Scope
Linked Issues
Follow-up to #7161.