Repository navigation
fix(autofix): retry a model API error instead of stranding the PR #7247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0e1ff5b
fix(autofix): retry a model API error instead of stranding the PR
ec6e644
fix(autofix): scope + broaden the retryable model-API detection (review)
cbbbfad
test(autofix): cover the timeout guard and the OAuth-quota fallback (…
4451171
Merge branch 'main' into ci/autofix-agent-api-retry
yiliang114 f3e28ec
fix(autofix): anchor the API-error code, split retry budget by cause,…
55563e3
test(autofix): cover the auth-capped retry budget and Chinese API-err…
qwen-code-ci-bot 719991a
fix(autofix): short-circuit 400 as terminal and classify only the las…
qwen-code-ci-bot 5522ffb
fix(autofix): treat transport-level API failures as retryable
0216f01
Merge branch 'main' into ci/autofix-agent-api-retry
8956e0d
fix(autofix): address review — OAuth fallback override, comment accur…
qwen-code-ci-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Critical] The bare
exceededalternative matches non-transient 400 errors (e.g. "context length exceeded", "maximum token limit exceeded"), classifying them as recoverable and triggering retries that fail identically every time — contradicting the comment on line 76 that "A 400 malformed request … fails identically forever and stays terminal (no match)." — Failure scenario: the model returns[API Error: 400 Bad request: context length exceeded]→exceededmatches →agent-api-errormarker written → workflow stamps sentinel ts → retries up to MAX_ROUNDS on a permanent error, wasting CI minutes and delaying human takeover. The existing test only covers[API Error: 400 Bad request: malformed], which lacks the word "exceeded".— qwen3.8-max-preview via Qwen Code /review