Repository navigation
fix(cli): align npm update checks with global registry #7224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wenshao
merged 8 commits into
QwenLM:main
from
yiliang114:cx/fix-update-registry-relaunch
Jul 19, 2026
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2fd1484
fix(cli): make npm updates registry-consistent
yiliang114 75decb5
fix(cli): harden npm updates and exit handling
yiliang114 5c5b529
fix(cli): restart safely for automatic updates
yiliang114 47b4a63
Revert "fix(cli): restart safely for automatic updates"
yiliang114 e7f0e81
test(cli): cover update registry edge cases
yiliang114 ee56a77
fix(cli): resolve CLI path before global-npm match and harden update …
yiliang114 159e45f
Merge branch 'main' into cx/fix-update-registry-relaunch
wenshao 95643c2
test(cli): stub global-npm probe in updateCheck timeout tests
yiliang114 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion]
isGlobalNpmInstallationdoes not guard thePromise.allagainstENOENTfromrunGlobalNpm→getNpmCliPath, even though it already guards the subsequentcanonicalize(unresolvedGlobalRoot)call against the same error class. — Failure scenario: on a non-Windows host where the CLI path passeslooksLikeNpmPackagePathbut nonpmsymlink exists next toprocess.execPath(minimal Node.js install, broken symlink),getNpmCliPaththrowsENOENT. The error propagates uncaught intocheckForUpdatesDetailed's outer catch, returning{ status: 'error' }— the user sees "Failed to check for updates" on every startup instead of falling back toupdate-notifier.— qwen3.8-max-preview via Qwen Code /review