Repository navigation
fix(cli): align npm update checks with global registry #7224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wenshao
merged 8 commits into
QwenLM:main
from
yiliang114:cx/fix-update-registry-relaunch
Jul 19, 2026
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2fd1484
fix(cli): make npm updates registry-consistent
yiliang114 75decb5
fix(cli): harden npm updates and exit handling
yiliang114 5c5b529
fix(cli): restart safely for automatic updates
yiliang114 47b4a63
Revert "fix(cli): restart safely for automatic updates"
yiliang114 e7f0e81
test(cli): cover update registry edge cases
yiliang114 ee56a77
fix(cli): resolve CLI path before global-npm match and harden update …
yiliang114 159e45f
Merge branch 'main' into cx/fix-update-registry-relaunch
wenshao 95643c2
test(cli): stub global-npm probe in updateCheck timeout tests
yiliang114 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Immediate Automatic Update Relaunch | ||
|
|
||
| ## Problem | ||
|
|
||
| Updating a global installation in place while the interactive CLI is running | ||
| removes content-hashed chunks that the old process may still import. Deferring | ||
| the install until the user exits avoids that corruption, but delays every | ||
| automatic update and reopens a session the user intentionally closed. | ||
|
|
||
| ## Design | ||
|
|
||
| Reuse the existing update relaunch handoff: | ||
|
|
||
| 1. The post-render update check discovers an installable update. | ||
| 2. The UI exits with the update relaunch code after normal cleanup. If a model | ||
| or tool turn, prompt or automatic-notification queue, slash command, or | ||
| unsent draft is active, it waits for a safe idle boundary. | ||
| 3. The supervisor rechecks and installs the update after the child is gone. | ||
| 4. The stable launcher starts the updated CLI with the original options and | ||
| resumes the exact durable session without replaying the initial prompt. For | ||
| a session with no recorded messages, the handoff independently records | ||
| whether the initial prompt was already consumed: an unconsumed prompt still | ||
| runs, while an executed slash or shell command is not replayed. | ||
|
|
||
| The production wrapper supplies an explicit capability marker only after it | ||
| resolves a stable launcher, plus a private handoff file for the session ID. | ||
| Container and macOS sandboxes receive the same handoff. If no stable launcher | ||
| is available, or a conversation cannot be resumed because recording is | ||
| disabled or failed, keep the current manual guidance. Custom or manually | ||
| managed sandbox hosts remain manual. Windows standalone installs download in | ||
| the background but apply after exit because the running executable is locked. | ||
|
|
||
| ## Non-goals | ||
|
|
||
| This does not hot-swap modules in a running process or introduce versioned | ||
| installation directories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] The
main()function's consumption ofSKIP_INITIAL_PROMPT_ENV_VAR(clearingprompt,promptInteractive,query) has no test. Entry-point propagation is tested incli.test.tsand sandbox passthrough insandbox.test.ts, but the actual prompt-clearing behaviour inmain()is unexercised. — Concrete cost: if a future refactor dropsquery: undefined(or the entire block), a relaunched session would re-execute the original--queryor--promptargument despite the supervisor signalling it was already consumed. No test would catch this regression.— qwen3.8-max-preview via Qwen Code /review