-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(core): add opt-in built-in web_search backed by the DashScope Responses API #7215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7074b11
feat(core): add opt-in built-in web_search backed by the DashScope Re…
tanzhenxin 77920f1
Merge origin/main into feat/web-search-responses-api
tanzhenxin d08a4a2
fix(core): require HTTPS for the web_search backend; fail closed on u…
tanzhenxin 18a9bfb
chore(cli): remove test-leaked debug artifacts; gitignore the leaked …
tanzhenxin 7eeaa1b
fix(core): honor web_search's own result budget and salvage in-stream…
tanzhenxin 302cf3b
fix(cli): treat whitespace-only WEB_SEARCH_API_KEY as unset
tanzhenxin d187e02
fix(core): salvage failed-terminal web_search results and name the ex…
tanzhenxin 817d424
test(cli): cover web search suppression in safe and bare modes
tanzhenxin 466373d
fix(core): parse the search model selector once for both gate paths
tanzhenxin 51db9ed
fix(core): handle response.cancelled in the web_search terminal-event…
234837b
fix(core): cap opened URLs, suppress failed-item progress, note retry…
ca1efeb
fix(core): reject unresolved selector on env-declared web_search path…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
|
|
||
| # Debug-log directories leaked by CLI unit tests that resolve paths relative | ||
| # to the package dir instead of a temp dir (settings/config suites). | ||
| /custom/ | ||
| /first/ | ||
| /from-env/ | ||
| /workspace/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] The gitignore entries
/custom/,/first/,/from-env/,/workspace/use generic directory names anchored to thepackages/cli/root. — Concrete cost: if a developer later createspackages/cli/workspace/(orcustom/) as a real source or fixture directory,git add .silently skips it; the omission is invisible until a fresh clone hits a missing-module error. The namesworkspaceandcustomare common enough for this to be plausible.Consider fixing the root cause — the tests that resolve paths relative to the package dir instead of a temp dir (as the comment acknowledges) — or at minimum narrow the patterns to the test-specific stems that create them.
— qwen3.8-max-preview via Qwen Code /review