Skip to content

fix(integration): harden flaky interactive read-then-write test #7105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 2 commits into from
Jul 17, 2026
Merged

fix(integration): harden flaky interactive read-then-write test #7105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d13424a
fix(integration): harden flaky interactive read-then-write test
wenshao Jul 17, 2026
4b0050a
test(integration): tighten interactive write polling
yiliang114 Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions integration-tests/interactive/file-system-interactive.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,21 @@ describe('Interactive file system', () => {
true,
);

const newFileContent = rig.readFile(fileName);
expect(newFileContent).toBe('1.0.1');
// The tool call is logged once the model issues it, but the turn may
// still be settling (a failed edit can be retried) and the model may
// append a trailing newline. Poll the file until it reflects the new
// version instead of reading it once.
const updated = await rig.poll(
() => rig.readFile(fileName).trimEnd() === '1.0.1',
rig.getDefaultTimeout(),
200,
);
if (!updated) {
printDebugInfo(rig, rig._interactiveOutput, { toolCall });
}
expect(updated, 'Expected file content to be updated to 1.0.1').toBe(
true,
);
},
);
});
Loading