-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(cli): hide sticky task panel when agent is idle #7062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
20c0a2a
e34aa6c
400201a
3acd262
442feb2
461be4b
75de312
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -444,6 +444,7 @@ export class BackgroundAgentResumeService { | |
| // UI falls back to its generic orphan annotation. | ||
| parentAgentId: meta.parentAgentId, | ||
| depth: meta.depth, | ||
| model: meta.model, | ||
| }; | ||
| const entry = registry.register(registration); | ||
| recovered.push(entry); | ||
|
|
@@ -532,7 +533,7 @@ export class BackgroundAgentResumeService { | |
| // entry back to paused, so an at-capacity revive fails cleanly instead of | ||
| // stranding the entry as paused. | ||
| try { | ||
| registry.assertCanStartBackgroundAgent(); | ||
| registry.assertCanStartBackgroundAgent(entry.model); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] The resume recovery registration at line ~425 never sets Consider persisting the resolved model ID in — qwen3.7-max via Qwen Code /review |
||
| } catch (error) { | ||
| debugLogger.warn( | ||
| `[BackgroundAgentResume] Cannot revive "${agentId}": ` + | ||
|
|
@@ -579,7 +580,7 @@ export class BackgroundAgentResumeService { | |
| ); | ||
| } | ||
| try { | ||
| registry.assertCanStartBackgroundAgent(); | ||
| registry.assertCanStartBackgroundAgent(entry.model); | ||
| } catch (error) { | ||
| debugLogger.warn( | ||
| `[BackgroundAgentResume] Cannot revive "${agentId}": ` + | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] The description says "Takes precedence over the global maxParallelAgents" but the implementation enforces
min(global, perModel)— the global cap always wins. The test "enforces the global cap even when the per-model cap has room" explicitly proves this: a per-model cap of 5 with a global cap of 1 results in an effective cap of 1. The same inaccurate phrasing ("Overrides the globalmaxParallelAgents") also appears in the JSDoc atpackages/core/src/config/config.ts:837.Failure scenario: A user sets
maxParallelAgentsByModel: { "weak-model": 5 }with globalmaxParallelAgents: 2, expecting weak-model to run up to 5 agents. The actual cap is 2 — the description misleads.— qwen3.7-max via Qwen Code /review