chore: fix typos in code comments and a Java SDK example - #7059
Conversation
- intentially -> intentionally (cli/src/gemini.tsx comment) - Attemtping -> Attempting (cli/src/ui/types.ts comment) - overrided -> overridden (core/src/test-utils/mock-tool.ts comment) - devlop -> develop (sdk-java SessionExample.java example prompt, x2)
|
Thanks for the PR! Template looks good ✓ Problem: Real typos confirmed in source — Direction: Aligned. Comment and example-string spelling fixes carry zero runtime risk. No direction concerns. Size: 5 additions + 5 deletions across 4 files, all in comments or a test-example string literal. No production logic lines changed. Not applicable for core module thresholds. Approach: Scope is minimal and focused — exactly the four stated typos, nothing else. Grouping them into one PR is the right call. Moving on to code review. 🔍 中文说明感谢贡献! 模板完整 ✓ 问题:源码中确认存在真实拼写错误—— 方向:对齐。注释和示例字符串拼写修正零运行风险,无方向顾虑。 规模:4 个文件,5 行增加 + 5 行删除,全部为注释或测试示例字符串字面量。未改动任何生产逻辑行。不适用核心模块阈值。 方案:范围最小且聚焦——恰好四处拼写错误,无多余改动。合并为一个 PR 是正确选择。 进入代码审查 🔍 — Qwen Code · qwen3.7-max Reviewed at |
Code ReviewIndependent proposal: grep for the stated typos, fix each one in place — single-character corrections in comments and a string literal. Nothing more needed. Diff comparison: matches exactly. Every change is a correct spelling fix at the right location. No logic touched, no scope creep, no drive-by refactors. Clean. No critical blockers. No AGENTS.md violations. Verification (Before / After)This PR fixes comments and a test-example string — no user-visible behavior to test in tmux. Instead, I ran the author's own verification grep as a before/after check: Before (main branch — typos present)5 hits across 4 files — matches the PR's claim exactly. After (PR applied — typos gone)Zero hits. All four typos corrected, no collateral damage. 中文说明代码审查独立方案: grep 声明的拼写错误,逐个原地修正——注释和字符串字面量的单字符更正,无需更多。 Diff 对比: 完全吻合。每处改动都是正确位置的拼写修正。未触及逻辑,无范围蔓延,无顺手重构。干净。 无关键阻塞项,无 AGENTS.md 违规。 验证(修复前/后)本 PR 修正注释和测试示例字符串——无用户可见行为可用 tmux 测试。改为运行作者自身的验证 grep 作为 before/after 检查: 修复前:4 个文件中 5 处命中,与 PR 声明完全一致。 修复后:0 处命中,四处拼写全部修正,无附带损伤。 — Qwen Code · qwen3.7-max Reviewed at |
|
Confidence: 5/5 — clean across every stage, no reservations. Four spelling typos, four correct fixes, zero risk. The diff is exactly what the PR says — comment and string-literal corrections with no logic changes. Before/after grep confirms all typos are gone and nothing else was touched. Well-scoped, well-documented, easy to review and revert. Ships it. 中文说明置信度:5/5 — 各阶段均通过,无保留意见。 四处拼写错误,四处正确修正,零风险。Diff 与 PR 描述完全一致——注释和字符串字面量修正,无逻辑改动。修复前后 grep 确认所有拼写错误已消除且无附带影响。范围清晰,文档完善,易于审查和回滚。可以合并。 — Qwen Code · qwen3.7-max Reviewed at |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
— qwen3.7-max via Qwen Code /review
Local build & real verification report (for merge reference)Independently verified at head Checks performed
Note on the single local cli test failure
Evidence1. Typo grep oracle — before (main, 5 hits) / after (PR head, 0 hits) + whole-repo residual sweep: 2. Format / lint / full build / targeted tests + A/B control for the pre-existing failure: ConclusionComment/string-literal-only change with zero behavioral surface, fully consistent with its description, no residual typos repo-wide, build and blast-radius tests green locally, CI green. Ready to merge. 中文版本本地构建与真实验证报告(供合并参考)在隔离 worktree 中于 head 已执行的检查
关于本地唯一一个 cli 测试失败的说明
证据见上方两张截图:① 拼写错误 grep 前后对照(main 5 处命中 / PR head 0 命中)+ 全仓残留扫描;② 格式化 / lint / 全量构建 / 定向测试 + 预存失败的 A/B 对照。 结论纯注释/字符串字面量改动,无任何行为面,与描述完全一致,全仓无拼写残留,本地构建与影响面测试全绿,CI 绿色。可以合并。 |


What this PR does
Fixes four spelling typos in code comments and one Java SDK example prompt. No behavior changes.
intentiallyintentionallypackages/cli/src/gemini.tsx(comment)AttemtpingAttemptingpackages/cli/src/ui/types.ts(comment)overridedoverriddenpackages/core/src/test-utils/mock-tool.ts(comment)devlop×2developpackages/sdk-java/.../SessionExample.java(example prompt string)Why it's needed
Minor readability cleanup. These are grouped into one PR rather than four micro-PRs to keep review overhead low.
Reviewer Test Plan
How to verify
grep -rn -e intentially -e Attemtping -e overrided -e devlop packages --include='*.ts' --include='*.tsx' --include='*.java'returns nothing (remaining hits, if any, are only in generateddist//coverage/artifacts that regenerate on build).Evidence (Before & After)
gemini.tsx:// We intentially omit the list of extensions …→// We intentionally omit the list of extensions …types.ts:// Attemtping to authenticate or re-authenticate→// Attempting to authenticate or re-authenticatemock-tool.ts:// Should be overrided in test file. …→// Should be overridden in test file. …SessionExample.java:session.sendPrompt("devlop Fibonacci function by python", …)→session.sendPrompt("develop Fibonacci function by python", …)(both call sites)Tested on
macOS:
prettier --check+eslintclean on the three TypeScript files; confirmed git tracks only the four intended source files (generateddist//coverage/copies are git-ignored). The Java change is a string literal in a test example. Windows/Linux: N/A — comment/string edits with no platform-dependent behavior.Environment (optional)
Node v24;
@qwen-code/qwen-codemonorepo.Risk & Scope
Linked Issues
None.
中文说明
本 PR 的作用
修复代码注释中的四处拼写错误,以及一个 Java SDK 示例提示语。无行为改动。
intentiallyintentionallypackages/cli/src/gemini.tsx(注释)AttemtpingAttemptingpackages/cli/src/ui/types.ts(注释)overridedoverriddenpackages/core/src/test-utils/mock-tool.ts(注释)devlop×2developpackages/sdk-java/.../SessionExample.java(示例提示字符串)为什么需要
轻量的可读性清理。将这些合并到一个 PR 而非四个微型 PR,以降低复核开销。
复核测试计划
如何验证
grep -rn -e intentially -e Attemtping -e overrided -e devlop packages --include='*.ts' --include='*.tsx' --include='*.java'无任何结果(若仍有命中,仅存在于会在构建时重新生成的dist//coverage/产物中)。证据(修复前后对比)
gemini.tsx:// We intentially omit the list of extensions …→// We intentionally omit the list of extensions …types.ts:// Attemtping to authenticate or re-authenticate→// Attempting to authenticate or re-authenticatemock-tool.ts:// Should be overrided in test file. …→// Should be overridden in test file. …SessionExample.java:session.sendPrompt("devlop Fibonacci function by python", …)→session.sendPrompt("develop Fibonacci function by python", …)(两处调用)测试环境
macOS:三个 TypeScript 文件的
prettier --check与eslint均无问题;确认 git 仅跟踪四个目标源文件(生成的dist//coverage/副本已被 git 忽略)。Java 改动为测试示例中的字符串字面量。Windows/Linux:N/A——注释/字符串编辑,无平台相关行为。运行环境(可选)
Node v24;
@qwen-code/qwen-codemonorepo。风险与影响范围
关联 Issue
无。