fix(web-shell): correct stale composerTagIcons import in ScheduledTasksDialog - #6748
Merged
Conversation
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
qwen-code-ci-bot
approved these changes
Jul 12, 2026
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅
— qwen3.7-max via Qwen Code /review
yiliang114
approved these changes
Jul 12, 2026
ytahdn
approved these changes
Jul 12, 2026
ytahdn
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅
— qwen3.7-max via Qwen Code /review
doudouOUC
approved these changes
Jul 12, 2026
doudouOUC
left a comment
Collaborator
There was a problem hiding this comment.
No issues found. LGTM! ✅
— qwen3.7-max via Qwen Code /review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix broken Vite build on
maincaused by a stale import inScheduledTasksDialog.tsx.Root cause
PR #6537 consolidated
client/components/composerTagIcons.ts→client/utils/composerTag.ts, deleting the old file and updating all existing imports.PR #6589 was branched before that consolidation and added a new import in
ScheduledTasksDialog.tsx:Since PR #6537 never touched
ScheduledTasksDialog.tsx, there was no merge conflict — but the target file no longer exists, breaking the production build.Fix
Update the import path to
'../../utils/composerTag'.Reviewer test plan
npm run build --workspace=packages/web-shellsucceeds (the step that fails onmain).中文版本
概述
修复
main分支上因ScheduledTasksDialog.tsx中的过期 import 导致的 Vite 构建失败。根因
PR #6537 将
client/components/composerTagIcons.ts整合到了client/utils/composerTag.ts,删除了旧文件并更新了所有已有引用。PR #6589 的分支基于整合之前的代码,在
ScheduledTasksDialog.tsx中新增了一行 import:由于 PR #6537 从未修改过
ScheduledTasksDialog.tsx,合并时没有冲突——但目标文件已不存在,导致生产构建失败。修复
将 import 路径更正为
'../../utils/composerTag'。验证方式
npm run build --workspace=packages/web-shell能够成功构建(该步骤在main上失败)。