Skip to content

fix(tests): sync qwen-resolve-workflow test expectations with PR #6706 - #6720

Merged
yiliang114 merged 1 commit into
QwenLM:mainfrom
yiliang114:fix/test-timeout-expectations
Jul 11, 2026
Merged

fix(tests): sync qwen-resolve-workflow test expectations with PR #6706#6720
yiliang114 merged 1 commit into
QwenLM:mainfrom
yiliang114:fix/test-timeout-expectations

Conversation

@yiliang114

Copy link
Copy Markdown
Collaborator

Summary

PR #6706 updated the review-pr workflow timeout values (job timeout 200→260m, default 120→180m, max 180→240m) but the corresponding test expectations in scripts/tests/qwen-resolve-workflow.test.js were not updated, causing CI test failures on all subsequent PRs.

Fixes 2 failing tests:

  • allows maintainers to extend review timeout from /review comments
  • tells maintainers how to retry timed-out reviews with more time

Changes

  • timeout-minutes: 200260
  • DEFAULT_TIMEOUT_MINUTES=120180
  • timeout_minutes must not exceed 180 minutes240 minutes
  • @qwen-code /review --timeout=180--timeout=240
  • maximum 180 minute timeoutmaximum 240 minute timeout

Test plan

  • Verify Test (ubuntu-latest, Node 22.x) passes on this PR (the two previously failing tests should now pass)

…LM#6706 timeout changes

PR QwenLM#6706 updated review-pr workflow timeout values (job timeout to 260m,
default to 180m, max to 240m) but did not update the corresponding test
expectations, causing CI failures on all subsequent PRs.
@qwen-code-ci-bot

Copy link
Copy Markdown
Collaborator

Thanks for the PR!

Template: the body uses custom headings (Summary / Changes / Test plan) instead of the PR template headings (What this PR does / Why it's needed / Reviewer Test Plan / Risk & Scope / Linked Issues / 中文说明). For a 5-line test sync the content is clear enough, but future PRs should follow the template — it helps reviewers and release notes.

Problem: real and well-evidenced. PR #6706 (merged today) updated the review workflow timeouts (120→180 default, 180→240 max, 200→260 job) but didn't update the corresponding test expectations, breaking CI for every subsequent PR.

Direction: clearly aligned — syncing broken test expectations to unblock CI. No product direction concerns.

Size: not applicable (test file only, no core modules touched).

Approach: minimal and correct. Five string replacements, one file, exactly matching the workflow changes from #6706. No scope creep. Moving on to code review. 🔍

中文说明

感谢贡献!

模板:PR 使用了自定义标题(Summary / Changes / Test plan),与 PR 模板 要求的标题不一致。对于 5 行测试同步来说内容足够清晰,但后续 PR 请遵循模板。

问题:真实且有据可查。PR #6706(今日合并)更新了 review 工作流超时时间但未同步测试,导致 CI 失败。

方向:完全对齐——修复测试以恢复 CI。无产品方向问题。

规模:不适用(仅测试文件)。

方案:最小且正确。5 处字符串替换,1 个文件,与 #6706 的工作流变更完全匹配。进入代码审查 🔍

Qwen Code · qwen3.7-max

@qwen-code-ci-bot

Copy link
Copy Markdown
Collaborator

Code Review

Independent proposal: update the 5 hardcoded timeout strings in the test file to match the workflow values from PR #6706. The diff matches exactly — same file, same strings, same values. No correctness bugs, no AGENTS.md violations, nothing to flag.

Verified each expectation against qwen-code-pr-review.yml:

  • timeout-minutes: 260 ✓ (workflow line 350)
  • DEFAULT_TIMEOUT_MINUTES=180 ✓ (workflow line 401)
  • timeout_minutes must not exceed 240 minutes ✓ (workflow line 688)
  • @qwen-code /review --timeout=240 ✓ (workflow line 806)
  • maximum 240 minute timeout ✓ (workflow line 808)

Testing

Test-only fix — no user-visible behavior to tmux-test. Unit test run suffices:

 ✓ scripts/tests/qwen-resolve-workflow.test.js (25 tests) 25ms

 Test Files  1 passed (1)
      Tests  25 passed (25)

All 25 tests pass, including the two previously failing:

  • allows maintainers to extend review timeout from /review comments
  • tells maintainers how to retry timed-out reviews with more time

Qwen Code · qwen3.7-max

@qwen-code-ci-bot

Copy link
Copy Markdown
Collaborator

This is a clean, mechanical fix: PR #6706 updated the workflow timeouts but forgot to update the test expectations, breaking CI. This PR does exactly what's needed — 5 string replacements in 1 test file — and nothing more. Every changed line maps 1:1 to a value in the workflow file. All 25 tests pass.

The only note is the template deviation (custom headings instead of the PR template), mentioned in Stage 1. Not blocking for this PR.

Approving.

中文说明

这是一个干净、机械性的修复:PR #6706 更新了工作流超时值但遗漏了测试期望,导致 CI 失败。本 PR 做了需要做的全部——1 个测试文件中的 5 处字符串替换——没有多余内容。25 个测试全部通过。

唯一注意点是模板偏差(Stage 1 已提及),不阻塞本 PR。

批准合并。

Qwen Code · qwen3.7-max

@qwen-code-ci-bot qwen-code-ci-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks ready to ship. ✅

@qwen-code-ci-bot qwen-code-ci-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No review findings. Downgraded from Approve to Comment: CI still running.

— qwen3.7-max via Qwen Code /review

@yiliang114
yiliang114 enabled auto-merge July 11, 2026 07:40
@yiliang114
yiliang114 requested a review from wenshao July 11, 2026 07:41
@yiliang114
yiliang114 added this pull request to the merge queue Jul 11, 2026
Merged via the queue into QwenLM:main with commit 55eb832 Jul 11, 2026
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants