-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(core): use consistent error response for plan mode blocked tools #6667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] Setting
erroranderrorTypehere is the correct fix, but it causes a behavioral side effect:BaseJsonOutputAdapter.ts(lines 1039-1049) records intopermission_denialswheneverresponse.erroris truthy anderrorType === EXECUTION_DENIED. Plan-mode-blocked tool calls were previously invisible to that tracker (both fields wereundefined). They will now appear alongside actual user-declined permission denials in SDK/non-interactive JSON output, with no discriminator field (e.g.,reason: "plan_mode"vsreason: "user_declined").If any SDK consumer iterates
permission_denialsto decide whether to re-prompt the user or abort, plan-mode blocks will be misclassified as user rejections.Consider either filtering plan-mode blocks out of
permissionDenials, or adding a discriminator toCLIPermissionDenial.— qwen3.7-max via Qwen Code /review