Skip to content

fix(mobile-mcp): reject out-of-range normalized coordinates #6656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LaZzyMan merged 1 commit into from
Jul 10, 2026
Merged

fix(mobile-mcp): reject out-of-range normalized coordinates #6656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/mobile-mcp/src/coord-norm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { ActionableError } from './robot';

// coord-norm.ts — Opt-in 0–1000 relative-coordinate shim for mobile-mcp.
//
// Mirrors packages/cua-driver's coord_norm.rs design. Default off = pixel
Expand Down Expand Up @@ -93,6 +95,12 @@ export function denormalizeArgs(

for (const { field, isX } of fields) {
if (typeof args[field] === 'number') {
if (args[field] < 0 || args[field] > scale) {
throw new ActionableError(
`Coordinate '${field}' value ${args[field]} is out of the normalized range [0, ${scale}]. ` +
`Use normalized coordinates (0-${scale}), not pixel coordinates.`,
);
}
const dim = isX ? screenWidth : screenHeight;
args[field] = normToPx(args[field], dim, scale);
}
Expand All @@ -103,6 +111,12 @@ export function denormalizeArgs(
toolName === 'mobile_swipe_on_screen' &&
typeof args.distance === 'number'
) {
if (args.distance < 0 || args.distance > scale) {
throw new ActionableError(
`Swipe 'distance' value ${args.distance} is out of the normalized range [0, ${scale}]. ` +
`Use normalized coordinates (0-${scale}), not pixel values.`,
);
}
const dir = args.direction;
const dim = dir === 'up' || dir === 'down' ? screenHeight : screenWidth;
args.distance = normToPx(args.distance, dim, scale);
Expand Down
Loading