docs: document tools.disabled and tools.visible settings - #6641
Conversation
Both settings are implemented and wired end to end (settingsSchema.ts, normalizeDisabledTools.ts, ToolRegistry registration gate) but were missing from the settings reference, while their deprecated siblings tools.core / tools.exclude / tools.allowed are documented. In particular, tools.disabled already answers a recurring user request: disabling enter_plan_mode entirely so the model can never switch into plan mode on its own (QwenLM#5970). Documenting it makes that option discoverable.
|
Thanks for the PR! Template looks good ✓ — all required sections present (What, Why, Reviewer Test Plan). Problem: Real and observable. Direction: Clearly aligned — documenting existing, tested settings is straightforward documentation work. No direction concerns. Size: Not applicable — docs-only, no core paths touched. Approach: Minimal and focused — exactly two table rows, placed correctly between the deprecated tool settings. Descriptions verified against Moving on to code review. 🔍 中文说明感谢贡献! 模板完整 ✓ — 所有必填章节齐全(What、Why、Reviewer Test Plan)。 问题:真实可观测的问题。 方向:明确对齐——为已实现、已测试的 settings 补充文档,是纯文档工作,无方向顾虑。 规模:不适用——仅文档改动,未触及核心路径。 方案:最小且聚焦——恰好两行表格,放在已废弃工具 settings 之间,位置正确。描述已与 进入代码审查 🔍 — Qwen Code · qwen3.7-max |
Code ReviewIndependent proposal (before reading diff): I would have read Comparison: The PR's approach matches exactly. Two rows, correctly positioned between the deprecated Findings: No issues.
No critical blockers. No AGENTS.md violations. This is a clean docs addition. TestingThis is a docs-only change (two markdown table rows) — there is no runtime behavior to test in tmux. Verification was done by:
— Qwen Code · qwen3.7-max |
|
This is a clean, minimal docs PR that does exactly one thing and does it well. The gap is real: The two rows are accurate — I verified descriptions against Nothing extraneous. No scope creep. The kind of PR that's a pleasure to review. Approving. ✅ 中文说明这是一个干净、最小化的文档 PR,只做了一件事且做得很好。 缺失是真实的: 两行描述准确——已逐行对照 没有多余内容,没有范围蔓延。 批准 ✅ — Qwen Code · qwen3.7-max |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
No review findings. Downgraded from Approve to Comment: CI still running.
— qwen3.7-max via Qwen Code /review
wenshao
left a comment
There was a problem hiding this comment.
No issues found. LGTM! ✅
— qwen3.7-max via Qwen Code /review
What this PR does
Adds the missing settings-reference rows for
tools.disabledandtools.visibleindocs/users/configuration/settings.md.Why it's needed
Both settings are implemented and wired end to end (settings schema,
normalizeDisabledTools.ts, and theToolRegistryregistration gate, which has test coverage intool-registry.test.ts), but neither appears in the settings reference. Their deprecated siblingstools.core,tools.exclude, andtools.allowedare all documented, so users find the deprecated options and miss the live ones.This matters in practice:
tools.disabledalready answers a recurring request. For example, #5970 asked for "an option to disable Plan Mode" so the model can never switch into plan mode on its own, and{"tools": {"disabled": ["enter_plan_mode"]}}does exactly that today. It just was not discoverable.Reviewer Test Plan
How to verify
Docs-only change. Confirm the two new rows match the source of truth in
packages/cli/src/config/settingsSchema.ts(thetools.disabledandtools.visibleentries, includingMergeStrategy.UNION) and the registration behavior inpackages/core/src/tools/tool-registry.ts(isToolDisabledgate). Prettier was run via the repo pre-commit hook.Evidence (Before & After)
N/A (docs table rows only).
Tested on