-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(cli): keep model switches session-scoped #6579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
1d6940f
fix(cli): keep model switches session-scoped
zjunothing 77da2b8
Merge branch 'main' into fix/model-session-default
wenshao c044a02
fix(cli): add model command translations
zjunothing bf724cc
Merge branch 'main' into fix/model-session-default
wenshao a6e995d
Merge branch 'main' into fix/model-session-default
wenshao b6e9b58
Merge branch 'main' into fix/model-session-default
wenshao a36e33d
Merge branch 'main' into fix/model-session-default
wenshao 4044ff7
Merge branch 'main' into fix/model-session-default
wenshao 60cc536
Merge branch 'main' into fix/model-session-default
wenshao 0a01d89
Merge branch 'main' into fix/model-session-default
wenshao d57bdf0
Merge branch 'main' into fix/model-session-default
wenshao 7b7cb51
Merge branch 'main' into fix/model-session-default
wenshao 02b23fc
Merge branch 'main' into fix/model-session-default
wenshao d6e7252
merge(main): combine --default and --image flags in model command
qwen-code-dev-bot ff7e91d
Merge branch 'main' into fix/model-session-default
wenshao 1adfab3
fix(cli): preserve model command persistence semantics
zjunothing d1c23dc
Merge branch 'main' into fix/model-session-default
wenshao ded4336
fix(cli): address review feedback on /model --default (#6579)
6e81163
chore(cli): merge main into fix/model-session-default
9cbc430
Merge branch 'main' into fix/model-session-default
qwen-code-dev-bot fdac9fd
test(cli): cover resolved config baseUrl in default model picker
qwen-code-dev-bot f893109
fix(cli): restrict --default flag parsing to leading positions (#6579)
qwen-code-ci-bot 991395a
test(cli): cover selectedType persistence for --default with explicit…
qwen-code-ci-bot 5b12caf
test(cli): cover --voice and --vision in --default mutual-exclusion g…
qwen-code-ci-bot db59eb8
test(cli): cover --default --global direct-switch and trailing-flag f…
qwen-code-ci-bot 78df51b
fix(cli): show inline-prompt rejection before scope guard in /model (…
qwen-code-ci-bot ed0ac4f
fix(cli): point inline-prompt rejection hint at working --default com…
qwen-code-ci-bot 9246bbf
fix(cli): address review feedback on --default model persistence (#6579)
qwen-code-ci-bot 237b2ed
fix(cli): align model persistence docs and locales (#6579)
zjunothing 44be9d7
fix(cli): detect trailing --default after whitespace runs and aux fla…
qwen-code-ci-bot a90f499
Merge branch 'main' into fix/model-session-default
qwen-code-ci-bot c50a114
Merge remote-tracking branch 'origin/main' into fix/model-session-def…
qwen-code-ci-bot 56d62ff
Merge branch 'main' into fix/model-session-default
qwen-code-dev-bot 5152271
fix(cli): align --default docs and rejections with persistence behavi…
qwen-code-ci-bot 7e9cc4d
Merge branch 'fix/model-session-default' of https://github.com/zjunot…
qwen-code-dev-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion]
docs/users/features/commands.mdwas not updated for the new persistence semantics — Failure scenario: a user upgrading from the pre-PR behavior (plain/model <id>persisted the model) opens the command reference to find how to persist a default model and sees the/model,/model --fast,/model --voice,/model --visionrows with no--defaultanywhere on the page — concluding the persist capability was removed rather than moved behind a flag.That page contains zero
--defaultmentions at this commit (grep-verified), and no note that plain/modelswitches are now session-scoped, while this diff updated three other docs pages (auth.md — this hunk, model-providers.md, settings.md) for exactly this change. The maintainer review (item 6) asked for a docs line because this is an intentional breaking change to behavior people rely on; the file is not touched by any commit in this PR.Suggested fix: add a
/model --defaultrow next to the existing/modelrow (e.g.| → --default | Persist the main model for future sessions | /model --default <model-id>, /model --default --project <model-id> |) and note in the/modelrow that plain switches are session-scoped.中文说明
[Suggestion]
docs/users/features/commands.md没有针对新的持久化语义更新 —— 失败场景:从旧行为(普通/model <id>会持久化模型)升级的用户打开命令参考,想找到持久化默认模型的方法,却只看到/model、/model --fast、/model --voice、/model --vision行,整页没有任何--default—— 会以为持久化能力被移除了,而不是挪到了标志后面。该页面在当前提交中没有出现任何
--default(已用 grep 验证),也没有说明普通/model切换现在是会话级的;而本 diff 为同一语义变更更新了另外三个文档页面(auth.md —— 即本行、model-providers.md、settings.md)。维护者评审(第 6 项)要求补一行文档,因为这是用户依赖的行为上有意的破坏性变更;该文件不在本 PR 的任何提交中。建议修复:在现有
/model行旁增加/model --default行(例如| → --default | 为后续会话持久化主模型 | /model --default <model-id>、/model --default --project <model-id> |),并在/model行注明普通切换仅作用于当前会话。— qwen3.8-max via Qwen Code /review (v0.21.3)