fix(web-shell): make dialog backdrop z-index configurable - #6572
Conversation
|
Thanks for the PR! Template looks good ✓ Problem: The web-shell package already exposes Direction: Aligned. Making the dialog backdrop z-index configurable completes the z-index customization pattern that tooltip and popover already follow. Low-risk CSS change that brings consistency to the embedded host API. CHANGELOG has no direct reference, but the area (web-shell customization) is clearly relevant. Size: Not applicable — change is in Approach: The scope is exactly right — a single-line change following the established Moving on to code review. 🔍 中文说明感谢贡献! 模板完整 ✓ 问题:web-shell 包已经通过 方向:对齐。让 dialog backdrop z-index 可配置,补齐了 tooltip 和 popover 已有的 z-index 定制模式。低风险的 CSS 改动,为嵌入式宿主 API 带来一致性。CHANGELOG 无直接参考,但该领域(web-shell 定制化)明显相关。 规模:不适用——改动在 方案:范围恰到好处——单行改动,完全遵循已有的 进入代码审查 🔍 — Qwen Code · qwen3.7-max |
|
Code Review: Clean — no issues found. The diff is a single-line CSS change: The implementation:
Testing: Tmux real-scenario testing is not applicable for this change. The modification is a CSS custom property in the web-shell package — it only manifests when a browser renders the web-shell UI. Running 中文说明代码审查: 干净——未发现问题。 Diff 是一个单行 CSS 改动: 实现方面:
测试: Tmux 真实场景测试不适用于本次改动。该修改是 web-shell 包中的 CSS 自定义属性——仅在浏览器渲染 web-shell UI 时才会体现。在终端中运行 — Qwen Code · qwen3.7-max |
|
This is a textbook minimal change. One line of CSS that completes a customization pattern the codebase already started with tooltip and popover z-index properties. The author clearly studied the existing conventions and replicated them exactly — same naming scheme, same fallback value, same CSS custom property approach. There's nothing to simplify, nothing to cut, nothing to question. The problem is real and self-evident: the z-index customization surface had a gap. Tooltip and popover layers were configurable; dialog backdrop wasn't. For embedded hosts that need to coordinate stacking contexts across all their UI layers, this gap meant the dialog backdrop was the one piece they couldn't control. The fix closes that gap without changing any default behavior. Approving. ✅ 中文说明这是一个教科书级的最小改动。一行 CSS,补齐了代码库中 tooltip 和 popover z-index 属性已经开始的定制模式。作者显然研究了现有规范并完全复制了它——相同的命名方案、相同的 fallback 值、相同的 CSS 自定义属性方式。无需简化、无需删减、无需质疑。 问题是真实且显而易见的:z-index 定制接口存在一个缺口。Tooltip 和 popover 层可配置;dialog backdrop 不可配置。对于需要协调所有 UI 层层叠上下文的嵌入式宿主来说,这个缺口意味着 dialog backdrop 是唯一无法控制的部分。该修复在不改变任何默认行为的前提下填补了这个缺口。 批准。✅ — Qwen Code · qwen3.7-max |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
What this PR does
Makes the Web Shell dialog backdrop z-index configurable through a CSS custom property,
--web-shell-dialog-backdrop-z-index, while preserving the existing default stacking behavior.Why it's needed
Web Shell already exposes z-index customization for tooltip and popover layers through
--web-shell-tooltip-z-indexand--web-shell-popover-z-index. Dialog backdrops still used a hard-coded z-index, which made embedded hosts coordinate modal layering less consistently. This change brings the dialog backdrop in line with the existing customization pattern without changing the default value.Reviewer Test Plan
How to verify
Set
--web-shell-dialog-backdrop-z-indexon:rootorbody, open any Web Shell dialog, and confirm the backdrop uses the configured stacking level. With no custom property set, dialogs should continue to use the previous effective z-index of 1000.Evidence (Before & After)
N/A
Tested on
Environment (optional)
Ran
npm run build --workspace @qwen-code/web-shell.Risk & Scope
Linked Issues
N/A
中文说明
这个 PR 做了什么
这个 PR 通过 CSS 自定义属性
--web-shell-dialog-backdrop-z-index让 Web Shell 的 dialog backdrop z-index 可配置,同时保留现有默认层级行为。为什么需要
Web Shell 目前已经通过
--web-shell-tooltip-z-index和--web-shell-popover-z-index支持 tooltip 和 popover 层级的自定义。Dialog backdrop 仍然使用硬编码 z-index,嵌入式宿主在协调自己的 modal、overlay 或 shell 容器层级时不够一致。这个改动让 dialog backdrop 与已有的 z-index 自定义模式保持一致,同时不改变默认值。Reviewer Test Plan
如何验证
在
:root或body上设置--web-shell-dialog-backdrop-z-index,打开任意 Web Shell dialog,确认 backdrop 使用配置后的层级。未设置该自定义属性时,dialog 应继续使用之前等效的 z-index 1000。证据(Before & After)
N/A
测试平台
环境(可选)
执行了
npm run build --workspace @qwen-code/web-shell。风险与范围
关联 Issue
N/A