Repository navigation
feat(hooks): add MessageDisplay hook for mid-turn streaming #6489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e699238
feat(hooks): add MessageDisplay hook for mid-turn streaming
yanchenko f5c76f4
fix(hooks): address MessageDisplay review feedback
yanchenko 43d3621
Merge remote-tracking branch 'origin/main' into feat/message-display-…
yanchenko 85e6f31
test(hooks): drain microtasks before asserting on chained MessageDisp…
yanchenko dd355fa
fix(hooks): flush MessageDisplay is_final on every for-await exit path
yanchenko c89a691
Merge main into feat/message-display-hook
yanchenko 63f8454
fix(hooks): fire MessageDisplay on the ACP surface, coalesce delivery…
yanchenko a2b8fe5
fix(hooks): bound MessageDisplay drain wait, fix test gaps flagged in…
yanchenko 2064017
fix(hooks): dispatch MessageDisplay is_final alongside stale deliveri…
yanchenko 73add3d
refactor(core): consolidate MessageDisplay finish() calls, dedupe tes…
yanchenko 3465aea
Merge branch 'main' into feat/message-display-hook
wenshao a2ab71c
docs(hooks): clarify MessageDisplay cancellation timing (round-4 nit)
yanchenko 1f005f0
test(hooks): cover the 3 untested MessageDisplay dispatch sites, fix …
yanchenko 8972eb6
Merge branch 'main' into feat/message-display-hook
yanchenko 240da43
Merge branch 'main' into feat/message-display-hook
yanchenko 50cdf3e
Merge branch 'main' into feat/message-display-hook
yanchenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] MessageDisplay integration tests exist only for the ACP prompt path (this usage site). The Stop-hook continuation loop (~line 2282), daemon interactive loop (~line 3321), and daemon background-notification loop (~line 3638) each create their own
MessageDisplayDispatcherwith independenttry/finallywiring, so a regression in any of them would not be caught by the tests here.Consider adding one test per remaining usage site verifying at minimum: (a)
is_final: trueis delivered exactly once with cumulative non-thought text, and (b) abort suppressesis_final. The existing test scaffolding for those loops can be extended with the same mock pattern used here.— qwen3.7-max via Qwen Code /review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same fix as the other coverage-gap comment on this review — see my reply there. All three remaining MessageDisplay usage sites (Stop-hook continuation, cron, background-notification) now have tests.