Repository navigation
fix(core): emit auth URL as OSC 8 hyperlink instead of hard-wrapping #6433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8aecb37
fix(core): emit auth URL as OSC 8 hyperlink instead of hard-wrapping
DennisYu07 f8a74c5
fix(test): clear CI env vars in showFallbackMessage tests
DennisYu07 4049c14
Merge branch 'main' into fix/auth-url-osc8-hyperlink
DennisYu07 ac3c32e
Merge branch 'main' into fix/auth-url-osc8-hyperlink
DennisYu07 bd81d45
Merge branch 'main' into fix/auth-url-osc8-hyperlink
DennisYu07 87db5f0
fix(test): add TERM_PROGRAM_VERSION to OSC 8 detection tests
DennisYu07 046b701
Merge branch 'main' into fix/auth-url-osc8-hyperlink
DennisYu07 5f06425
Merge branch 'main' into fix/auth-url-osc8-hyperlink
wenshao 519c9c8
fix(core): add DCS passthrough wrapping and align OSC 8 detection wit…
1ffcdc7
fix(core): pad OSC 8 URL line, extend sanitization to bidi controls (…
99a36b8
fix(core): align auth OSC 8 detection with reference, fix VTE parsing…
f84f65a
Merge branch 'main' into fix/auth-url-osc8-hyperlink
193e367
Merge branch 'main' into fix/auth-url-osc8-hyperlink
qwen-code-dev-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] Missing URL scheme validation in
osc8Hyperlink(). The function embeds the URL directly into an OSC 8 envelope without checking if the URL scheme is safe. The canonicalosc8Hyperlink()inpackages/cli/src/ui/utils/osc8.tsusesisSafeOscScheme()to restrict targets tohttp:,https:,mailto:,ftp:,ftps:,sftp:,ssh:. A compromised OAuth endpoint returning ajavascript:URL asverification_uri_completewould be rendered as a clickable OSC 8 hyperlink.— qwen3.7-max via Qwen Code /review