Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .qwen/skills/triage/references/pr-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ gh pr review "$PR_NUMBER" --repo "$REPO" --request-changes --body-file /tmp/stag
```

If the author cannot provide a reproduction on re-run, escalate to the maintainer (use `$QWEN_MAINTAINER_HANDLE` if set) and stop — do not proceed to Stage 2.

- **No reproduction = no fix.** A `fix:` PR without reproduction is a hypothesis — belongs in issues, not PRs.

**"direction is correct" ≠ "problem exists."** If the runtime already handles the case correctly, there is no bug — only code hygiene. Code hygiene does not warrant a PR.
Expand Down
9 changes: 5 additions & 4 deletions packages/cli/src/acp-integration/acpAgent.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1354,10 +1354,11 @@ describe('QwenAgent MCP SSE/HTTP support', () => {
].join(path.delimiter);

try {
await expectAcpLocalReadRoots(
'session-with-fs-env',
[...expectedDefaultAcpLocalReadRoots(), envRootA, envRootB],
);
await expectAcpLocalReadRoots('session-with-fs-env', [
...expectedDefaultAcpLocalReadRoots(),
envRootA,
envRootB,
]);
} finally {
restoreOptionalEnv(acpLocalReadRootsEnv, previousRoots);
}
Expand Down
60 changes: 60 additions & 0 deletions packages/web-shell/client/App.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,58 @@
overflow: visible;
}

.missingSessionState {
flex: 1 1 auto;
min-height: 0;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
gap: 18px;
padding: 24px;
color: var(--foreground);
font-family: var(--font-sans);
}

.missingSessionMessage {
font-size: inherit;
font-weight: inherit;
line-height: 1.4;
text-align: center;
}

.missingSessionButton {
min-width: 120px;
min-height: 38px;
padding: 0 16px;
border: 1px solid var(--border);
border-radius: var(--radius);
background: var(--primary);
color: var(--primary-foreground);
font: inherit;
font-size: 14px;
cursor: pointer;
transition:
border-color 120ms ease,
opacity 120ms ease;
}

.missingSessionButton:hover,
.missingSessionButton:focus-visible {
Comment thread
ytahdn marked this conversation as resolved.
border-color: color-mix(in srgb, var(--foreground) 24%, var(--border));
opacity: 0.9;
}

.missingSessionButton:focus-visible {
box-shadow: 0 0 0 2px color-mix(in srgb, var(--foreground) 12%, transparent);
outline: none;
}

.missingSessionButton:disabled {
cursor: not-allowed;
opacity: 0.5;
}

/* In-place panel that replaces the chat view (message list + composer) when
Settings or Daemon Status is opened. Fills the chat pane and owns its own
scroll container, mirroring what the DialogShell body used to provide. */
Expand Down Expand Up @@ -478,6 +530,14 @@
display: none;
}

.chatSubtree {
display: contents;
}

.chatSubtreeHidden {
display: none;
}

/* Empty (new-chat) state centers the welcome header + composer vertically via
`.appChatEmpty .chatPane { justify-content: center }`. For that to take effect
the wrapper must shrink to its content instead of filling the pane — the same
Expand Down
Loading
Loading