fix(vscode): keep auth quick inputs open on focus loss - #6274
Conversation
VS Code dismisses QuickPick and InputBox prompts on focus loss unless ignoreFocusOut is enabled, which breaks the multi-step auth flow when users switch windows to copy provider details. Constraint: VS Code extension API defaults ignoreFocusOut to false for quick inputs Confidence: high Scope-risk: narrow Tested: npm test --workspace=packages/vscode-ide-companion -- src/webview/handlers/AuthMessageHandler.test.ts Tested: npm run check-types --workspace=packages/vscode-ide-companion Tested: npm run lint --workspace=packages/vscode-ide-companion Tested: npm run build --workspace=packages/vscode-ide-companion Tested: git diff --check
|
Thanks for the PR @barry166! Template headings deviate slightly from the PR template — uses "Summary"/"Testing"/"Notes" instead of the standard "What this PR does"/"Why it's needed"/"Reviewer Test Plan" headings, and "Risk & Scope" is absent. The substance is all there though — what changed is clear, testing commands are listed, and the linked issue #6230 provides motivation. Not blocking on this, but worth aligning for future PRs. On direction: straightforward bug fix for #6230 — the auth QuickPick and InputBox close when the user switches focus away (e.g. to copy a model name or API endpoint), forcing them to start over. On approach: minimal and focused — 2 files, +9 lines, adds Moving on to code review. 🔍 中文说明感谢贡献 @barry166! 模板标题和标准模板有偏差——用了"Summary"/"Testing"/"Notes",缺少"Why it's needed"和"Risk & Scope"章节。不过实质内容都在——改动清晰,测试命令已列出,关联的 #6230 提供了动机。不因此阻断,但建议后续 PR 对齐模板。 方向:修复 /auth 过程中 QuickPick/InputBox 失焦关闭的问题(比如用户切窗口复制模型名或 API 地址时,之前的输入全部丢失)。 方案:精简聚焦——2 个文件,+9 行,在封装所有 进入代码审查 🔍 — Qwen Code · qwen3.7-max |
Code reviewThe fix adds
Since every QuickPick and InputBox call in the auth flow goes through these two helpers, the fix is complete — no missed call sites. Tests add No blockers. No AGENTS.md violations. TestingThis is a VS Code extension GUI change — the 中文说明代码审查修复在
所有 QuickPick 和 InputBox 调用都经过这两个辅助函数,修复完整无遗漏。 测试通过 无阻断问题,无 AGENTS.md 违规。 测试这是 VS Code 扩展 GUI 改动, 结果:10 个测试全部通过,TypeScript 编译无错误, — Qwen Code · qwen3.7-max |
|
This is a clean, focused bug fix. The PR does exactly what it says — adds The linked issue (#6230) describes a real frustration: switching windows to copy a model name or API endpoint causes the entire auth flow to reset. The fix is a one-line addition per helper, and the tests verify both call sites correctly. No blockers from code review. Unit tests pass (10/10). Type check clean. The only nit is the PR template heading names, which I flagged in Stage 1 but aren't worth blocking on. Approving. ✅ 中文说明干净聚焦的 bug 修复。PR 做了它该做的事——在封装所有 VS Code QuickPick 和 InputBox 调用的两个辅助函数中添加 关联 issue #6230 描述了真实的用户痛点:切换窗口复制模型名或 API 地址会导致整个 auth 流程重置。修复每个辅助函数只加一行,测试验证了两个调用点都正确。 代码审查无阻断问题。单元测试 10/10 通过。类型检查干净。唯一的瑕疵是模板标题名称(Stage 1 已提及),不值得阻断。 批准合入 ✅ — Qwen Code · qwen3.7-max |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
No review findings. Downgraded from Approve to Comment: CI still running.
— qwen3.7-max via Qwen Code /review
doudouOUC
left a comment
There was a problem hiding this comment.
No issues found. LGTM! ✅
— qwen3.7-max via Qwen Code /review
Summary
Fixes #6230.
Testing
npm test --workspace=packages/vscode-ide-companion -- src/webview/handlers/AuthMessageHandler.test.tsnpm run check-types --workspace=packages/vscode-ide-companionnpm run lint --workspace=packages/vscode-ide-companionnpm run build --workspace=packages/vscode-ide-companiongit diff --checkNotes
AI-assisted: yes. I manually reviewed the diff and test output before opening this PR.
I did not manually exercise the VS Code QuickPick/InputBox UI because the regression is covered through the mocked VS Code API options in
AuthMessageHandler.test.ts.