fix(mobile-mcp): add production-release environment to CD workflow for npm auth - #6258
Conversation
|
Thanks for the PR! Template: headings differ from the project template ( On direction: this is a straightforward CI fix — the CD workflow fails with ENEEDAUTH because On approach: the changes are minimal and exactly mirror the proven patterns from Moving on to code review. 🔍 中文说明感谢贡献! 模板:标题与项目模板不一致( 方向:直接的 CI 修复——CD workflow 因为 方案:改动极小,完全对齐 进入代码审查 🔍 — Qwen Code · qwen3.7-max |
Code ReviewIndependent proposal (before seeing the diff): the ENEEDAUTH error points to the The PR matches this proposal exactly — and adds npm caching as a free optimization. No correctness issues, no security concerns. The No blockers. LGTM on the code. TestingThis PR modifies a GitHub Actions workflow file — tmux real-scenario testing is N/A (no user-facing behavior to drive). Validation performed: CI checks are pending on the PR. The author's test plan (yamllint + actionlint pass, trigger dry-run after merge, trigger publish after dry-run passes) is the correct validation path for a workflow change. 中文说明代码审查独立方案(看 diff 之前):ENEEDAUTH 错误指向 PR 完全匹配这个方案,还加了 npm 缓存作为免费优化。无正确性问题,无安全顾虑。 无阻塞项,代码 LGTM。 测试本 PR 修改的是 GitHub Actions workflow 文件——tmux 真实场景测试不适用(无用户可见行为可驱动)。已验证:YAML 语法合法。CI 检查正在运行中。作者的测试计划(yamllint + actionlint 通过、merge 后触发 dry-run、dry-run 通过后触发 publish)是 workflow 变更的正确验证路径。 — Qwen Code · qwen3.7-max |
|
This is a clean, minimal CI fix that does exactly what it says — aligns the mobile-mcp CD workflow's npm auth with the proven The diff is 9 additions and 6 deletions in a single YAML file. Every change maps to a specific, justified alignment with The only minor note is the PR body heading mismatch with the template, but the content quality is high — root cause analysis, clear test plan, and honest self-assessment ("Should have been caught before the first PR"). Approving. ✅ 中文说明干净、最小化的 CI 修复,完全对齐 diff 在单个 YAML 文件中 +9/-6,每处改动都有明确的对齐理由。无顺手重构,无范围蔓延。 唯一的小瑕疵是 PR 正文标题与模板不一致,但内容质量很高——有根因分析、清晰的测试计划、诚实的自省。 通过。✅ — Qwen Code · qwen3.7-max |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship. ✅
…kflow for npm auth
The merge-base changed after approval.
10880e7 to
57d8574
Compare
|
Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. 中文请勿对活跃的 PR 执行 rebase 或 force-push,因为这会使已有的评审评论失效。另外,供日后参考:作为集成流程的一部分,机器人始终会自动将所有改动压缩(squash)为单个提交。 |
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
qwen-code-ci-bot
left a comment
There was a problem hiding this comment.
No review findings. Downgraded from Approve to Comment: CI still running.
— qwen3.7-max via Qwen Code /review
Summary
Fix npm publish ENEEDAUTH in cd-mobile-mcp.yml.
NPM_TOKENis an environment secret bound toproduction-release— withoutenvironment:the workflow gets an empty token.Changes (vs the version merged in #6255):
environment: name: 'production-release'(matching release.yml / release-sdk.yml)scope: '@qwen-code'to setup-node--provenance(release.yml doesn't use it).nvmrcfor node version (matching release.yml)Root cause
The original cd-mobile-mcp.yml was written without referencing the existing release.yml's npm auth setup. Should have been caught before the first PR.
Test plan