fix(cua-driver): migrate Windows scripts + add /mcp Approve button - #6241
Merged
Conversation
The install script's baked version was still pointing at 0.6.8, requiring users to manually specify CUA_DRIVER_RS_VERSION=0.7.0.
qwen-code-ci-bot
previously requested changes
Jul 3, 2026
qwen-code-ci-bot
left a comment
qwen-code-ci-bot
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR, @LaZzyMan!
Unfortunately the PR body doesn't follow our pull request template — the required headings (What this PR does, Why it's needed, Reviewer Test Plan, Risk & Scope, etc.) are missing. Could you update the description to match the template? It helps reviewers (and future-you) understand the context quickly.
The change itself looks straightforward — happy to re-run triage once the template is in place. 🙏
中文说明
感谢贡献，@LaZzyMan！
PR 正文缺少我们 PR 模板 中的必填标题（What this PR does、Why it's needed、Reviewer Test Plan、Risk & Scope 等）。麻烦按模板更新一下描述，方便 reviewer 快速理解上下文。
改动本身看起来很简单——模板补齐后会重新跑 triage。🙏
— Qwen Code · qwen3.7-max
DragonnZhang
approved these changes
Jul 3, 2026
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
LaZzyMan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes discovered during Windows cua-driver 0.7.0 testing:
1. Windows install/uninstall scripts un-migrated from upstream
install.ps1anduninstall.ps1were essentially un-migrated — binary name wascua-driver.exe(upstream) instead ofqwen-cua-driver.exe, repo pointed attrycua/cua, install paths used upstream vendor names.cua-driver.exe→qwen-cua-driver.exetrycua/cua→QwenLM/qwen-codePrograms\Cua\cua-driver\→Programs\Qwen\qwen-cua-driver\.cua-driver→.qwen-cua-drivercua-driver-serve→qwen-cua-driver-serveBAKED_VERSION:0.6.8→0.7.0post-install-hints.txtand_install-rust.shfallback2.
/mcpUI missing Approve buttonUsers who missed the startup approval dialog or rejected a workspace MCP server had no way to approve it from the
/mcpmanagement interface — onlyDisablewas shown, creating a dead end.Added an
Approvebutton toServerDetailStepfor any server inawaitingApprovalstate (both pending and rejected). The handler persists the approval, un-gates the server, triggers discovery, and refreshes the UI.Test plan
install.ps1: verified$BinaryName = "qwen-cua-driver.exe",$Repo = "QwenLM/qwen-code", zerotrycua/cuareferencesuninstall.ps1: mirrored all renames/mcp→ Approve button visible → click Approve → status transitions todisconnectedwith Reconnect option